Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP Server setting is ignored #536

Open
vanakema opened this issue Dec 14, 2024 · 0 comments
Open

LSP Server setting is ignored #536

vanakema opened this issue Dec 14, 2024 · 0 comments

Comments

@vanakema
Copy link

Describe the bug
When setting the LSP Server setting to ruff server, it no longer seems to have an effect

To Reproduce
Prereqs: I am using Poetry as my package manager, with pyenv for managing python versions

  1. Install this Ruff plugin in PyCharm
  2. Change plugin settings to Enable Ruff LSP feature and use ruff server
  3. Save settings
  4. Observe that IJ shows an error for the ruff language server; the error is: pyenv: ruff-lsp: command not found

Expected behavior
It should respect the setting and launch ruff server instead.

Screenshots
Ruff Server Error Output:

pyenv: ruff-lsp: command not found

The `ruff-lsp' command exists in these Python versions:
  3.11.9
Note: See 'pyenv help global' for tips on allowing both
      python2 and python3 to be found.
Exit code: 127
Command line: /Users/markvanaken/.pyenv/shims/ruff-lsp
StdIO connection closed

Plugin settings screenshot
Screenshot 2024-12-13 at 7 08 35 PM

Environments (please complete the following information):

  • IDE: PyCharm 2024.3.1 (Professional Edition)
  • OS: macOS Sequoia 15.0.1
  • Ruff Version 0.7.4
  • Plugin version 0.0.42

Additional context
Bear in mind I do have ruff-lsp installed for a different python version. Maybe the plugin just straight up ignores that setting if ruff-lsp is installed. But that behavior would be bad for a number of reasons, on top of ruff-lsp no longer being the preferred way of running the ruff LSP. See the note on the ruff-lsp repo: https://github.com/astral-sh/ruff-lsp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant