From 5268a5f154913dfe971e63bb4a42715102e53b56 Mon Sep 17 00:00:00 2001 From: Jeppe Reinhold Date: Mon, 20 Jan 2025 11:17:52 +0100 Subject: [PATCH] disable flaky test-runner tests --- code/core/template/stories/args.stories.ts | 3 ++- code/core/template/stories/decorators.stories.ts | 3 ++- code/core/template/stories/globals.stories.ts | 3 ++- code/core/template/stories/rendering.stories.ts | 2 ++ .../CustomRenderOptionsArgsFromData.stories.ts | 2 ++ 5 files changed, 10 insertions(+), 3 deletions(-) diff --git a/code/core/template/stories/args.stories.ts b/code/core/template/stories/args.stories.ts index 4c83a98ca0ae..2cd7d684eb68 100644 --- a/code/core/template/stories/args.stories.ts +++ b/code/core/template/stories/args.stories.ts @@ -92,5 +92,6 @@ export const Events = { await new Promise((resolve) => channel.once(STORY_ARGS_UPDATED, resolve)); await within(canvasElement).findByText(/updated/); }, - tags: ['!vitest'], + // this story can't be reliably tested because the args changes results in renderPhases disrupting test runs + tags: ['!vitest', '!test'], }; diff --git a/code/core/template/stories/decorators.stories.ts b/code/core/template/stories/decorators.stories.ts index aa5cb1b6d496..f7afd7ae922f 100644 --- a/code/core/template/stories/decorators.stories.ts +++ b/code/core/template/stories/decorators.stories.ts @@ -67,5 +67,6 @@ export const Hooks = { }); await new Promise((resolve) => channel.once(STORY_ARGS_UPDATED, resolve)); }, - tags: ['!vitest'], + // this story can't be reliably tested because the args changes results in renderPhases disrupting test runs + tags: ['!vitest', '!test'], }; diff --git a/code/core/template/stories/globals.stories.ts b/code/core/template/stories/globals.stories.ts index 0afd7d1fc44d..a62eaa77f34f 100644 --- a/code/core/template/stories/globals.stories.ts +++ b/code/core/template/stories/globals.stories.ts @@ -44,7 +44,8 @@ export const Events = { await channel.emit('updateGlobals', { globals: { foo: 'fooValue' } }); await within(canvasElement).findByText('fooValue'); }, - tags: ['!vitest'], + // this story can't be reliably tested because the globals changes results in renderPhases disrupting test runs + tags: ['!vitest', '!test'], }; export const Overrides1 = { diff --git a/code/core/template/stories/rendering.stories.ts b/code/core/template/stories/rendering.stories.ts index 77e9432ef512..179572d1c18c 100644 --- a/code/core/template/stories/rendering.stories.ts +++ b/code/core/template/stories/rendering.stories.ts @@ -105,4 +105,6 @@ export const ChangeArgs = { await within(canvasElement).findByText(/New Text/); await expect(button).toHaveFocus(); }, + // this story can't be reliably tested because the args changes results in renderPhases disrupting test runs + tags: ['!vitest', '!test'], }; diff --git a/code/renderers/vue3/template/stories_vue3-vite-default-ts/CustomRenderOptionsArgsFromData.stories.ts b/code/renderers/vue3/template/stories_vue3-vite-default-ts/CustomRenderOptionsArgsFromData.stories.ts index 2670bc8e17cf..427ec3602e43 100644 --- a/code/renderers/vue3/template/stories_vue3-vite-default-ts/CustomRenderOptionsArgsFromData.stories.ts +++ b/code/renderers/vue3/template/stories_vue3-vite-default-ts/CustomRenderOptionsArgsFromData.stories.ts @@ -34,6 +34,8 @@ const meta = { `, }); }, + // this story can't be reliably tested because the (inherited) args changes results in renderPhases disrupting test runs + tags: ['!vitest', '!test'], } satisfies Meta; export default meta;