If rebuilders return more than one version for a given package, the first one is lost

[albert-astals-cid-kdab]

See https://reproducible.archlinux.org/api/v0/pkgs/list?distro=archlinux at the moment, it's returning two automake versions, so when doing return {x['name']: [x['version'], x['status']] for x in req.json()} the first one is lost and it tells me that automake is not reproducible when in fact it is

[albert-astals-cid-kdab]

Mega hackish solution

diff --git a/ismyarchverifiedyet.py b/ismyarchverifiedyet.py
index 326e400..380d2f4 100755
--- a/ismyarchverifiedyet.py
+++ b/ismyarchverifiedyet.py
@@ -27,7 +27,7 @@ def get_rebuilds(rebuilder):
     print(f'[*] Fetching {url}')
     req = requests.get(url)
     req.raise_for_status()
-    return {x['name']: [x['version'], x['status']] for x in req.json()}
+    return {x['name']+'@'+x['version']: x['status'] for x in req.json()}
 
 
 def get_installed_pkgs():
@@ -42,8 +42,7 @@ def main(status):
     good = 0
 
     for name, version in packages:
-        versions = [build[name] for build in rebuilds if name in build]
-        statuses = [status for ver, status in versions if ver == version]
+        statuses = [build[name+'@'+version] for build in rebuilds if name+'@'+version in build]
 
         confirmations = statuses.count('GOOD')
         good += THRESHOLD <= confirmations

but i guess there's a more pythonic way of doing that :D

[kpcyrd]

hey! Thanks for the bug report :) @ysf or @jelly might now what's the best solution here.

[jelly]

To make it clearer what the issue is, we have a [testing] repository which also contains automake:

[{'name': 'automake',
  'version': '1.16.2-3',
  'status': 'GOOD',
  'distro': 'archlinux',
  'suite': 'core',
  'architecture': 'any',
  'url': 'https://mirror.pkgbuild.com/core/os/x86_64/automake-1.16.2-3-any.pkg.tar.zst',
  'build_id': None,
  'built_at': None,
  'attestation': None,
  'next_retry': None},
 {'name': 'automake',
  'version': '1.16.3-1',
  'status': 'GOOD',
  'distro': 'archlinux',
  'suite': 'testing',
  'architecture': 'any',
  'url': 'https://mirror.pkgbuild.com/testing/os/x86_64/automake-1.16.3-1-any.pkg.tar.zst',
  'build_id': 4393,
  'built_at': '2020-12-03T19:13:37.531988504',
  'attestation': None,
  'next_retry': None}]