Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUSSPUNKT and STEIGUNG / added parameters, must be pulled manually #81

Closed
zimbo86 opened this issue Dec 10, 2024 · 9 comments
Closed

FUSSPUNKT and STEIGUNG / added parameters, must be pulled manually #81

zimbo86 opened this issue Dec 10, 2024 · 9 comments
Assignees

Comments

@zimbo86
Copy link

zimbo86 commented Dec 10, 2024

I added FUSSPUNKT and STEIGUNG HK1, however these parameters wont pull automatically and need to be pulled

wp_base.yaml

STEIGUNG_HK1:                   !include { file: wp_number.yaml, vars: { property: "STEIGUNG_HK1"               , min: "0", max: "5.0", step: "0.01", icon: "mdi:chart-bell-curve-cumulative"}}
FUSSPUNKT_HK1:                  !include { file: wp_number.yaml, vars: { property: "FUSSPUNKT_HK1"               , min: "0", max: "20", step: "0.1", icon: "mdi:download-outline"}}

property.h

PROPERTY(FUSSPUNKT_HK1, 0x059e, Type::et_dec_val);
PROPERTY(STEIGUNG_HK1, 0x010e, Type::et_dec_val);
@kr0ner
Copy link
Owner

kr0ner commented Dec 10, 2024

They are related to HK1 so they should also have target: "HK1".
Number values are requested once at boot and after that, since they need to actively be changed, on reception. Maybe that is related to

if (!isResponse(msg))

and that was broken recently ... in this case the following should fix it

    if (isRequest(msg)) {
        return {Property::kINDEX_NOT_FOUND, value};
    }

@kr0ner kr0ner self-assigned this Dec 10, 2024
@zimbo86
Copy link
Author

zimbo86 commented Dec 10, 2024

ok, just struggeling implementing the modified common.yaml


substitutions:
  espclient_can_id: "0x6a2"
esphome:
  platformio_options:
    build_flags:
      - "-DESPCLIENT_ID= $espclient_can_id"

breaks compiling.
When removing subsition everything works fine.

esphome:
  platformio_options:
    build_flags:
      - "-DESPCLIENT_ID=0x6a2"

Maybe its related bc my esphome is outdated.. 2025.5

image

@zimbo86
Copy link
Author

zimbo86 commented Dec 10, 2024

.. modified the build_flags and used no subsitutions to test it.
Removed communications.h Line 111

     if (!isResponse(msg)) {
        ESP_LOGD("Communication", "Message is not a response. Dropping it!");
        return {Property::kINDEX_NOT_FOUND, value};
    }

with

if (isRequest(msg)) {
        return {Property::kINDEX_NOT_FOUND, value};
    }

however still no value for these two settings

@kr0ner
Copy link
Owner

kr0ner commented Dec 10, 2024

Did you add HK1 as target?

STEIGUNG_HK1:                   !include { file: wp_number.yaml, vars: { property: "STEIGUNG_HK1"               , min: "0", max: "5.0", step: "0.01", icon: "mdi:chart-bell-curve-cumulative", target: "HK1"}}
FUSSPUNKT_HK1:                  !include { file: wp_number.yaml, vars: { property: "FUSSPUNKT_HK1"               , min: "0", max: "20", step: "0.1", icon: "mdi:download-outline", target: "HK1"}}

@zimbo86
Copy link
Author

zimbo86 commented Dec 10, 2024

nope, I didnt. Your response time is pure madness :D

@zimbo86
Copy link
Author

zimbo86 commented Dec 10, 2024

that was the missing point, works!

image
(I use differnet names)

@zimbo86 zimbo86 closed this as completed Dec 10, 2024
@zimbo86
Copy link
Author

zimbo86 commented Dec 10, 2024

however one thing, STEIGUNG is listed as 1.8 instead 0.18, this could be an issue if you dont know it and want to change it..

@zimbo86 zimbo86 reopened this Dec 10, 2024
@kr0ner
Copy link
Owner

kr0ner commented Dec 10, 2024

try Type::et_cent_val instead of Type::et_dec_val

PROPERTY(STEIGUNG_HK1, 0x010e, Type::et_cent_val);

How is the value displayed in the heat pump display? 0.18 so cent_val should be fine

@zimbo86
Copy link
Author

zimbo86 commented Dec 10, 2024

that worked!

image

@zimbo86 zimbo86 closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants