Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs() call is broken #6

Closed
jake-ciolek opened this issue Oct 14, 2023 · 2 comments
Closed

Logs() call is broken #6

jake-ciolek opened this issue Oct 14, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jake-ciolek
Copy link
Contributor

jake-ciolek commented Oct 14, 2023 •
edited
Loading

The instance example is broken and the Logs() call doesn't work anymore:

could not get instance logs: performing the request: error parsing response: json: Unmarshal(non-pointer kraftcloud.ServiceResponse[sdk.kraft.cloud/instance.Instance])

Ran into it while trying to adapt kraftkit to the refactored sdk.
@jake-ciolek jake-ciolek added the bug Something isn't working label Oct 14, 2023
@antoineco
Copy link
Contributor

antoineco commented Oct 14, 2023 •
edited
Loading

I wonder how the linter didn't catch that. Maybe it doesn't descend into submodules.

Edit: yes, that was it

@antoineco
Copy link
Contributor

I tried locally with absolutely all linters enabled, and none of them detected the issue 🥲

jake-ciolek added a commit that referenced this issue Oct 14, 2023
@jake-ciolek
Fix Logs()
3620bee 
Use a pointer so unmarshalling works.

Given that the initial architecture is in place, to enhance stability,
the next effort could focus on implementing request/response tests.

Fixes #6

Signed-off-by: Jakub Ciolek <[email protected]>
jake-ciolek added a commit that referenced this issue Oct 14, 2023
@jake-ciolek
Fix Logs()
b7f6890 
Use a pointer so unmarshalling works.

Given that the initial architecture is in place, to enhance stability,
the next effort could focus on implementing request/response tests.

Fixes #6

Signed-off-by: Jakub Ciolek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antoineco @jake-ciolek