We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The onResize method in dom.js currently uses offsetWidth and offsetHeight to get the elements dimensions.
onResize
dom.js
offsetWidth
offsetHeight
These two attributes always return integer values--disregarding the fractional part
As some elements can have subpixel values, perhaps its worth it considering not to round the width and height to achieve a better precision.
I believe this is also causing the zoid library to sometimes generate slightly wrong iframe sizes, since the method seems to be used here
In case you are interested, I opened a draft PR with a suggested approach:
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
The
onResize
method indom.js
currently usesoffsetWidth
andoffsetHeight
to get the elements dimensions.These two attributes always return integer values--disregarding the fractional part
As some elements can have subpixel values, perhaps its worth it considering not to round the width and height to achieve a better precision.
I believe this is also causing the zoid library to sometimes generate slightly wrong iframe sizes, since the method seems to be used here
In case you are interested, I opened a draft PR with a suggested approach:
The text was updated successfully, but these errors were encountered: