Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary casts to double for nhits, num_misses, mem_size, seg_size, avail_mem in helper methods #473

Open
TysonAndre opened this issue Nov 13, 2022 · 0 comments

Comments

@TysonAndre
Copy link
Contributor

(For apcu_sma_info and apc_cache_info)

This doesn't really affect me, it's just surprising

See https://github.com/krakjoe/apcu/blob/master/tests/apcu_sma_info.phpt#L20

Those are internally represented as a zend_long for many of these, making the cast unnecessary, and the majority of installations would be 64-bit anyway. I'm not sure if this is a holdover to let it work for 32-bit builds (x32) on 64-bit oses

  • add_assoc_double was part of the initial import : 4639e9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant