From 467ded6b39e86eb6ea74906ea5f5e65cf8cc48f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=87etin=20ARDAL?= <kral2@users.noreply.github.com>
Date: Wed, 6 Oct 2021 12:50:39 +0200
Subject: [PATCH] fix: add version pinning on terraform modules

---
 CHANGELOG.md                                           | 2 +-
 README.md                                              | 5 ++---
 main.tf                                                | 7 +++++--
 release-notes/{relnote-v0.1.0.md => relnote-v0.1.1.md} | 0
 variables.tf                                           | 5 -----
 5 files changed, 8 insertions(+), 11 deletions(-)
 rename release-notes/{relnote-v0.1.0.md => relnote-v0.1.1.md} (100%)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5162906..c82732e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,7 +10,7 @@ Given a version number MAJOR.MINOR.PATCH:
 - MINOR version when adding functionality in a backwards compatible manner,
 - PATCH version when making backwards compatible bug fixes.
 
-## [0.1.0] - 2021-10-06
+## [0.1.1] - 2021-10-06
 
 Initial release.
 
diff --git a/README.md b/README.md
index 9e36ee2..ffadba2 100644
--- a/README.md
+++ b/README.md
@@ -30,8 +30,8 @@ This module deploys an instance with the necessary tools to start developing Inf
 
 | Name | Source | Version |
 |------|--------|---------|
-| <a name="module_instance_iacbox"></a> [instance\_iacbox](#module\_instance\_iacbox) | oracle-terraform-modules/compute-instance/oci | n/a |
-| <a name="module_vcn_iacbox"></a> [vcn\_iacbox](#module\_vcn\_iacbox) | oracle-terraform-modules/vcn/oci | n/a |
+| <a name="module_instance_iacbox"></a> [instance\_iacbox](#module\_instance\_iacbox) | oracle-terraform-modules/compute-instance/oci | 2.1.0 |
+| <a name="module_vcn_iacbox"></a> [vcn\_iacbox](#module\_vcn\_iacbox) | oracle-terraform-modules/vcn/oci | 3.0.0 |
 ## Resources
 
 | Name | Type |
@@ -58,7 +58,6 @@ This module deploys an instance with the necessary tools to start developing Inf
 | <a name="input_source_ocid"></a> [source\_ocid](#input\_source\_ocid) | The OCID of an image or a boot volume to use, depending on the value of source\_type. | `string` | n/a | yes |
 | <a name="input_source_type"></a> [source\_type](#input\_source\_type) | The source type for the instance. | `string` | `"image"` | no |
 | <a name="input_ssh_authorized_keys"></a> [ssh\_authorized\_keys](#input\_ssh\_authorized\_keys) | Public SSH keys path to be included in the ~/.ssh/authorized\_keys file for the default user on the instance. | `string` | n/a | yes |
-| <a name="input_subnet_ocids"></a> [subnet\_ocids](#input\_subnet\_ocids) | The unique identifiers (OCIDs) of the subnets in which the instance primary VNICs are created. | `list(string)` | n/a | yes |
 | <a name="input_tenancy_ocid"></a> [tenancy\_ocid](#input\_tenancy\_ocid) | n/a | `string` | `null` | no |
 | <a name="input_user_data"></a> [user\_data](#input\_user\_data) | Provide your own base64-encoded data to be used by Cloud-Init to run custom scripts or provide custom Cloud-Init configuration. | `string` | `null` | no |
 | <a name="input_user_ocid"></a> [user\_ocid](#input\_user\_ocid) | n/a | `string` | `null` | no |
diff --git a/main.tf b/main.tf
index 7d4e72a..ccee2e6 100644
--- a/main.tf
+++ b/main.tf
@@ -9,7 +9,8 @@ locals {
 }
 
 module "vcn_iacbox" {
-  source = "oracle-terraform-modules/vcn/oci"
+  source  = "oracle-terraform-modules/vcn/oci"
+  version = "3.0.0"
 
   # general oci parameters
   compartment_id = var.compartment_id
@@ -39,7 +40,9 @@ resource "oci_core_subnet" "vcn_iacbox_public" {
 }
 
 module "instance_iacbox" {
-  source = "oracle-terraform-modules/compute-instance/oci"
+  source  = "oracle-terraform-modules/compute-instance/oci"
+  version = "2.1.0"
+
   # general oci parameters
   compartment_ocid = var.compartment_id
   # freeform_tags    = var.freeform_tags
diff --git a/release-notes/relnote-v0.1.0.md b/release-notes/relnote-v0.1.1.md
similarity index 100%
rename from release-notes/relnote-v0.1.0.md
rename to release-notes/relnote-v0.1.1.md
diff --git a/variables.tf b/variables.tf
index bdda946..56d54b2 100644
--- a/variables.tf
+++ b/variables.tf
@@ -123,11 +123,6 @@ variable "assign_public_ip" {
   default     = true
 }
 
-variable "subnet_ocids" {
-  description = "The unique identifiers (OCIDs) of the subnets in which the instance primary VNICs are created."
-  type        = list(string)
-}
-
 ## storage parameters
 
 variable "block_storage_sizes_in_gbs" {