More robust API request/response handling #70

krazkidd · 2024-07-31T05:45:30Z

This fixes some issues with the Kalshi API service suddenly rejecting my client code. I had to add a User-Agent header and allow for non-JSON responses.

github-actions · 2024-07-31T05:46:09Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 9 file(s) not formatted

include/api/Api.hpp
include/api/Api.hxx
include/api/_Api.hpp
include/api/types.hpp
src/api/Api.auth.cpp
src/api/Api.cpp
src/api/Api.exchange.cpp
src/api/Api.market.cpp
src/api/Api.portfolio.cpp

clang-tidy reports: 301 concern(s)

include/api/Api.hpp:11:10: error: [clang-diagnostic-error]

'oatpp/parser/json/mapping/ObjectMapper.hpp' file not found
```
#include "oatpp/parser/json/mapping/ObjectMapper.hpp"
         ^
```

include/api/Api.hpp:31:56: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<ExchangeAnnouncementsResponse> GetExchangeAnnouncements();
                                                       ^

include/api/Api.hpp:32:51: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<ExchangeScheduleResponse> GetExchangeSchedule();
                                                  ^

include/api/Api.hpp:33:49: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<ExchangeStatusResponse> GetExchangeStatus();
                                                ^

include/api/Api.hpp:36:41: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        std::shared_ptr<EventsResponse> GetEvents();
                                        ^
```

include/api/Api.hpp:37:40: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<EventResponse> GetEvent(std::string_view eventTicker);
                                       ^

include/api/Api.hpp:38:42: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        std::shared_ptr<MarketsResponse> GetMarkets();
                                         ^
```
include/api/Api.hpp:39:41: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        std::shared_ptr<TradesResponse> GetTrades();
                                        ^
```

include/api/Api.hpp:40:41: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<MarketResponse> GetMarket(std::string_view marketTicker);
                                        ^

include/api/Api.hpp:41:50: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<MarketOrderbookResponse> GetMarketOrderbook(std::string_view marketTicker);
                                                 ^

include/api/Api.hpp:42:41: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<SeriesResponse> GetSeries(std::string_view seriesTicker);
                                        ^

include/api/Api.hpp:43:53: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<MarketCandlesticksResponse> GetMarketCandlesticks(std::string_view seriesTicker, std::string_view marketTicker);
                                                    ^

include/api/Api.hpp:46:16: warning: [modernize-use-trailing-return-type]

        double GetBalance();
        ~~~~~~ ^
        auto                -> double

include/api/Api.hpp:47:40: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        std::shared_ptr<FillsResponse> GetFills();
                                       ^
```
include/api/Api.hpp:48:41: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        std::shared_ptr<OrdersResponse> GetOrders();
                                        ^
```
include/api/Api.hpp:49:40: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        std::shared_ptr<OrderResponse> CreateOrder();
                                       ^
```

include/api/Api.hpp:50:40: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<OrderResponse> GetOrder(std::string_view orderId);
                                       ^

include/api/Api.hpp:51:46: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<CancelOrderResponse> CancelOrder(std::string_view orderId);
                                             ^

include/api/Api.hpp:52:45: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<AmendOrderResponse> AmendOrder(std::string_view orderId);
                                            ^

include/api/Api.hpp:53:40: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<OrderResponse> DecreaseOrder(std::string_view orderId);
                                       ^

include/api/Api.hpp:54:44: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        std::shared_ptr<PositionsResponse> GetPositions();
                                           ^
```

include/api/Api.hpp:55:55: warning: [modernize-use-trailing-return-type]

        std::shared_ptr<PortfolioSettlementsResponse> GetPortfolioSettlements();
                                                      ^

include/api/Api.hpp:58:14: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        bool IsLoggedIn();
        ~~~~ ^
        auto              -> bool
```

include/api/Api.hpp:60:51: warning: [modernize-use-trailing-return-type]

        std::list<std::shared_ptr<EventPosition>> GetEventPositions();
                                                  ^

include/api/Api.hpp:61:52: warning: [modernize-use-trailing-return-type]

        std::list<std::shared_ptr<MarketPosition>> GetMarketPositions(std::string_view eventTicker = "");
                                                   ^

include/api/Api.hpp:90:30: warning: [modernize-use-trailing-return-type]

        ApiResult<TResponse> HandleResponse(std::shared_ptr<oatpp::web::protocol::http::incoming::Response> response);
                             ^

include/api/Api.hxx:3:10: error: [clang-diagnostic-error]

'oatpp/core/Types.hpp' file not found
```
#include "oatpp/core/Types.hpp"
         ^
```
include/api/_Api.hpp:2:9: warning: [bugprone-reserved-identifier]

declaration uses identifier '_API_HPP', which is a reserved identifier
```
#define _API_HPP
        ^~~~~~~~
        API_HPP
```
include/api/_Api.hpp:4:10: error: [clang-diagnostic-error]

'oatpp/core/Types.hpp' file not found
```
#include "oatpp/core/Types.hpp"
         ^
```
include/api/_Api.hpp:13:11: warning: [bugprone-reserved-identifier]

declaration uses identifier '_Api', which is a reserved identifier
```
    class _Api
          ^~~~
          Api
```
include/api/types.hpp:4:10: error: [clang-diagnostic-error]

'oatpp/core/macro/codegen.hpp' file not found
```
#include "oatpp/core/macro/codegen.hpp"
         ^
```

include/api/types.hpp:11:5: warning: [modernize-use-using]

    typedef oatpp::String DateTime_Iso8601;
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    using DateTime_Iso8601 = int

include/api/types.hpp:13:5: warning: [modernize-use-using]

    typedef oatpp::String EasternTime_HH_MM;
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    using EasternTime_HH_MM = int

include/api/types.hpp:21:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(VoidResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:29:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(Error, DTO /* extends */)
        ^
```
include/api/types.hpp:32:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, message);
        ^
```
include/api/types.hpp:33:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, service);
        ^
```
include/api/types.hpp:41:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(ErrorResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:54:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(LoginRequest, DTO /* extends */)
        ^
```
include/api/types.hpp:57:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, password);
        ^
```
include/api/types.hpp:65:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(LoginResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:68:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, token);
        ^
```
include/api/types.hpp:79:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(Announcement, DTO /* extends */)
        ^
```
include/api/types.hpp:82:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, message);
        ^
```
include/api/types.hpp:83:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, status);
        ^
```
include/api/types.hpp:84:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, type);
        ^
```
include/api/types.hpp:92:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(MaintenanceWindow, DTO /* extends */)
        ^
```
include/api/types.hpp:95:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(DateTime_Iso8601, end_datetime);
        ^
```
include/api/types.hpp:103:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(DailyHours, DTO /* extends */)
        ^
```
include/api/types.hpp:106:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(EasternTime_HH_MM, close_time);
        ^
```
include/api/types.hpp:114:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(StandardHours, DTO /* extends */)
        ^
```
include/api/types.hpp:117:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Object<DailyHours>, monday);
        ^
```
include/api/types.hpp:118:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Object<DailyHours>, tuesday);
        ^
```
include/api/types.hpp:119:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Object<DailyHours>, wednesday);
        ^
```
include/api/types.hpp:120:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Object<DailyHours>, thursday);
        ^
```
include/api/types.hpp:121:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Object<DailyHours>, friday);
        ^
```
include/api/types.hpp:122:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Object<DailyHours>, saturday);
        ^
```
include/api/types.hpp:130:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(Schedule, DTO /* extends */)
        ^
```
include/api/types.hpp:133:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Object<StandardHours>, standard_hours);
        ^
```
include/api/types.hpp:141:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(ExchangeAnnouncementsResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:151:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(ExchangeScheduleResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:161:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(ExchangeStatusResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:164:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Boolean, trading_active);
        ^
```
include/api/types.hpp:175:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(EventsRequest, DTO /* extends */)
        ^
```
include/api/types.hpp:178:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int32, limit);
        ^
```
include/api/types.hpp:179:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, status);
        ^
```
include/api/types.hpp:180:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, series_ticker);
        ^
```
include/api/types.hpp:181:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Boolean, with_nested_markets);
        ^
```
include/api/types.hpp:189:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(Market, DTO /* extends */)
        ^
```
include/api/types.hpp:192:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Float64, cap_strike);
        ^
```
include/api/types.hpp:193:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, category);
        ^
```
include/api/types.hpp:194:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(DateTime_Iso8601, close_time);
        ^
```
include/api/types.hpp:197:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, event_ticker);
        ^
```
include/api/types.hpp:198:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(DateTime_Iso8601, expected_expiration_time);
        ^
```
include/api/types.hpp:199:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(DateTime_Iso8601, expiration_time);
        ^
```
include/api/types.hpp:200:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, expiration_value);
        ^
```
include/api/types.hpp:201:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(DateTime_Iso8601, fee_waiver_expiration_time);
        ^
```
include/api/types.hpp:202:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Float64, floor_strike);
        ^
```
include/api/types.hpp:203:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, functional_strike);
        ^
```
include/api/types.hpp:204:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, last_price);
        ^
```
include/api/types.hpp:205:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(DateTime_Iso8601, latest_expiration_time);
        ^
```
include/api/types.hpp:206:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, liquidity);
        ^
```
include/api/types.hpp:207:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, market_type);
        ^
```
include/api/types.hpp:208:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, no_ask);
        ^
```
include/api/types.hpp:209:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, no_bid);
        ^
```
include/api/types.hpp:210:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, no_sub_title);
        ^
```
include/api/types.hpp:211:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, notional_value);
        ^
```
include/api/types.hpp:212:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, open_interest);
        ^
```
include/api/types.hpp:213:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(DateTime_Iso8601, open_time);
        ^
```
include/api/types.hpp:214:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, previous_price);
        ^
```
include/api/types.hpp:215:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, previous_yes_ask);
        ^
```
include/api/types.hpp:216:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, previous_yes_bid);
        ^
```
include/api/types.hpp:217:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, response_price_units);
        ^
```
include/api/types.hpp:218:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, result);
        ^
```
include/api/types.hpp:219:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, risk_limit_cents);
        ^
```
include/api/types.hpp:220:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, rules_primary);
        ^
```
include/api/types.hpp:221:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, rules_secondary);
        ^
```
include/api/types.hpp:222:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int32, settlement_timer_seconds);
        ^
```
include/api/types.hpp:223:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, settlement_value);
        ^
```
include/api/types.hpp:224:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, status);
        ^
```
include/api/types.hpp:225:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, strike_type);
        ^
```
include/api/types.hpp:227:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, tick_size);
        ^
```
include/api/types.hpp:228:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, ticker);
        ^
```
include/api/types.hpp:229:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, title);
        ^
```
include/api/types.hpp:230:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, volume);
        ^
```
include/api/types.hpp:231:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, volume_24h);
        ^
```
include/api/types.hpp:232:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, yes_ask);
        ^
```
include/api/types.hpp:233:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, yes_bid);
        ^
```
include/api/types.hpp:234:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, yes_sub_title);
        ^
```
include/api/types.hpp:242:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(Event, DTO /* extends */)
        ^
```
include/api/types.hpp:246:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(List<Object<Market>>, markets);
        ^
```
include/api/types.hpp:247:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Boolean, mutually_exclusive);
        ^
```
include/api/types.hpp:248:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, series_ticker);
        ^
```
include/api/types.hpp:249:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(DateTime_Iso8601, strike_date);
        ^
```
include/api/types.hpp:250:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, strike_period);
        ^
```
include/api/types.hpp:251:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, sub_title);
        ^
```
include/api/types.hpp:252:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, title);
        ^
```
include/api/types.hpp:260:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(EventsResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:263:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(List<Object<Event>>, events);
        ^
```
include/api/types.hpp:271:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(EventResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:281:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(MarketsResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:284:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(List<Object<Market>>, markets);
        ^
```
include/api/types.hpp:292:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(MarketsRequest, DTO /* extends */)
        ^
```
include/api/types.hpp:295:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int32, limit);
        ^
```
include/api/types.hpp:296:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, event_ticker);
        ^
```
include/api/types.hpp:297:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, series_ticker);
        ^
```
include/api/types.hpp:298:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, max_close_ts);
        ^
```
include/api/types.hpp:299:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, min_close_ts);
        ^
```
include/api/types.hpp:300:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, status);
        ^
```
include/api/types.hpp:301:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, tickers);
        ^
```
include/api/types.hpp:309:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(Trade, DTO /* extends */)
        ^
```
include/api/types.hpp:312:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(DateTime_Iso8601, created_time);
        ^
```
include/api/types.hpp:313:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, no_price);
        ^
```
include/api/types.hpp:314:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, taker_side);
        ^
```
include/api/types.hpp:315:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, ticker);
        ^
```
include/api/types.hpp:316:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, trade_id);
        ^
```
include/api/types.hpp:317:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, yes_price);
        ^
```
include/api/types.hpp:325:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(TradesResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:328:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(List<Object<Trade>>, trades);
        ^
```
include/api/types.hpp:336:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(TradesRequest, DTO /* extends */)
        ^
```
include/api/types.hpp:339:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int32, limit);
        ^
```
include/api/types.hpp:340:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, ticker);
        ^
```
include/api/types.hpp:341:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, min_ts);
        ^
```
include/api/types.hpp:342:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, max_ts);
        ^
```
include/api/types.hpp:350:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(MarketResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:360:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(MarketOrderbook, DTO /* extends */)
        ^
```
include/api/types.hpp:363:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(List<Int32>, yes);
        ^
```
include/api/types.hpp:371:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(MarketOrderbookResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:381:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(SettlementSource, DTO /* extends */)
        ^
```
include/api/types.hpp:384:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, url);
        ^
```
include/api/types.hpp:392:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(Series, DTO /* extends */)
        ^
```
include/api/types.hpp:395:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, contract_url);
        ^
```
include/api/types.hpp:396:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, frequency);
        ^
```
include/api/types.hpp:397:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(List<Object<SettlementSource>>, settlement_sources);
        ^
```
include/api/types.hpp:398:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(List<String>, tags);
        ^
```
include/api/types.hpp:399:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, ticker);
        ^
```
include/api/types.hpp:400:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, title);
        ^
```
include/api/types.hpp:408:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(SeriesResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:418:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(Price, DTO /* extends */)
        ^
```
include/api/types.hpp:421:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, high);
        ^
```
include/api/types.hpp:422:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, low);
        ^
```
include/api/types.hpp:423:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, mean);
        ^
```
include/api/types.hpp:424:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, open);
        ^
```
include/api/types.hpp:425:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, previous);
        ^
```
include/api/types.hpp:433:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(YesAsk, DTO /* extends */)
        ^
```
include/api/types.hpp:436:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, high);
        ^
```
include/api/types.hpp:437:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, low);
        ^
```
include/api/types.hpp:438:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, open);
        ^
```
include/api/types.hpp:446:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(YesBid, DTO /* extends */)
        ^
```
include/api/types.hpp:449:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, high);
        ^
```
include/api/types.hpp:450:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, low);
        ^
```
include/api/types.hpp:451:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, open);
        ^
```
include/api/types.hpp:459:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(MarketCandlestick, DTO /* extends */)
        ^
```
include/api/types.hpp:462:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, open_interest);
        ^
```
include/api/types.hpp:463:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Object<Price>, price);
        ^
```
include/api/types.hpp:464:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, volume);
        ^
```
include/api/types.hpp:465:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Object<YesAsk>, yes_ask);
        ^
```
include/api/types.hpp:466:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Object<YesBid>, yes_bid);
        ^
```
include/api/types.hpp:467:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, ticker);
        ^
```
include/api/types.hpp:475:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(MarketCandlesticksResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:478:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, end_ts);
        ^
```
include/api/types.hpp:479:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int32, period_interval);
        ^
```
include/api/types.hpp:490:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(BalanceResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:494:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, payout);
        ^
```
include/api/types.hpp:502:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(FillsRequest, DTO /* extends */)
        ^
```
include/api/types.hpp:505:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, order_id);
        ^
```
include/api/types.hpp:506:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, min_ts);
        ^
```
include/api/types.hpp:507:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, max_ts);
        ^
```
include/api/types.hpp:508:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int32, limit);
        ^
```
include/api/types.hpp:509:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, cursor);
        ^
```
include/api/types.hpp:517:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(Fill, DTO /* extends */)
        ^
```
include/api/types.hpp:520:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int32, count);
        ^
```
include/api/types.hpp:521:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(DateTime_Iso8601, created_time);
        ^
```
include/api/types.hpp:522:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Boolean, is_taker);
        ^
```
include/api/types.hpp:523:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, no_price);
        ^
```
include/api/types.hpp:524:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, order_id);
        ^
```
include/api/types.hpp:525:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, side);
        ^
```
include/api/types.hpp:526:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, ticker);
        ^
```
include/api/types.hpp:527:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, yes_price);
        ^
```
include/api/types.hpp:535:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(FillsResponse, DTO /* extends */)
        ^
```
include/api/types.hpp:538:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Object<Fill>, fills);
        ^
```
include/api/types.hpp:546:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(OrdersRequest, DTO /* extends */)
        ^
```
include/api/types.hpp:549:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, event_ticker);
        ^
```
include/api/types.hpp:550:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, min_ts);
        ^
```
include/api/types.hpp:551:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int64, max_ts);
        ^
```
include/api/types.hpp:552:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, status);
        ^
```
include/api/types.hpp:553:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, cursor);
        ^
```
include/api/types.hpp:554:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int32, limit);
        ^
```
include/api/types.hpp:562:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_INIT(Order, DTO /* extends */)
        ^
```
include/api/types.hpp:565:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int32, amend_count);
        ^
```
include/api/types.hpp:566:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int32, amend_taker_fill_count);
        ^
```
include/api/types.hpp:567:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(String, client_order_id);
        ^
```
include/api/types.hpp:568:9: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
        DTO_FIELD(Int32, close_cancel_count);
        ^
```
src/api/Api.auth.cpp:5:10: error: [clang-diagnostic-error]

'api/Api.hpp' file not found
```
#include "api/Api.hpp"
         ^
```

Have any feedback or feature suggestions? Share it here.

krazkidd added 3 commits July 30, 2024 17:55

Add User-Agent header to all requests.

8347341

Put all GET request parameters in URL as query params.

4867d04

Check response MIME type and throw an error if not JSON.

84da87a

krazkidd linked an issue Jul 31, 2024 that may be closed by this pull request

Getting 403 from CloudFront WAF #69

Closed

krazkidd self-assigned this Jul 31, 2024

krazkidd merged commit c340558 into main Jul 31, 2024
1 check failed

krazkidd deleted the 69-getting-403-from-cloudfront-waf branch July 31, 2024 05:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More robust API request/response handling #70

More robust API request/response handling #70

krazkidd commented Jul 31, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024

More robust API request/response handling #70

More robust API request/response handling #70

Conversation

krazkidd commented Jul 31, 2024 • edited Loading

github-actions bot commented Jul 31, 2024

Cpp-Linter Report ⚠️

krazkidd commented Jul 31, 2024 •

edited

Loading