Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collision with Emacs 25 alist-get #23

Open
noelwelsh opened this issue Sep 21, 2017 · 0 comments
Open

Collision with Emacs 25 alist-get #23

noelwelsh opened this issue Sep 21, 2017 · 0 comments

Comments

@noelwelsh
Copy link

noelwelsh commented Sep 21, 2017 •
edited
Loading

Emacs 25 added an alist library, including alist-get. helm-spotify defines it's own alist-get function which collides with the new built-in. The helm-spotify version has a slightly different API and its shadowing of the built-in can break some packages. In my case magit broke. It would be good to remove this function and use the built-in instead.

Also, it seems like this package is unmaintained now. It would be good to make that official, if this the case, so someone else could take it over.

Thanks!
kouthi added a commit to kouthi/dotfiles that referenced this issue Jan 8, 2018
@kouthi
Delete spotify layer in spacemacs
f7118fc 
helm-spotify semms unmaintained and have huge problem in overwriting
function (alist-get) in emacs 25.
ref. krisajenkins/helm-spotify#23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noelwelsh