Add a sanitizeError option and specs #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error objects often contain information, such as the stack, that should not be exposed to the client. This adds the ability to give a `sanitizeError` function to the Connection that will be called whenever an Error is encoded. The return value of this function is used in place of the original error.
|
I, for one, would appreciate having such an ability to prevent leaking server information. Looks straightforward enough to serve my needs. |
|
I think that it might be sufficient to sanitize errors by default, and turn off sanitization with a debug option. Perhaps "debug" for one and "trace" for logging. |
|
@Stuk had a nice idea that benefitted from being able to alter how the sanitization happens: reporting some id for the exceptional event to the user for support purposes. (Though that sort of thing could be implemented without informing the end user, with the benefit of it appearing all the more magical) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error objects often contain information, such as the stack, that should not be exposed to the client.
This adds the ability to give a
sanitizeErrorfunction to the Connection that will be called whenever an Error is encoded. The return value of this function is used in place of the original error.