Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor app/object store #68

Open
krisnova opened this issue Aug 17, 2021 · 0 comments
Open

refactor app/object store #68

krisnova opened this issue Aug 17, 2021 · 0 comments

Comments

@krisnova
Copy link
Owner

with merging #67 we introduce some new paradigms

  • You can pass nil as a kube client to Install(client) and Uninstall(client)
  • There is a new interface method Objects() []runtime.Object

We should make our code a little cleaner, and have the object cache match what has been installed and uninstalled
We should make the object cache a hash map such that we can reference specific elements in the map as we install and uninstall them
We can pull the code generation out a little bit and tidy things up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant