Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old message in messageUpdate is equals to the new message #127

Open
PMunch opened this issue Sep 2, 2024 · 3 comments · May be fixed by #128
Open

Old message in messageUpdate is equals to the new message #127

PMunch opened this issue Sep 2, 2024 · 3 comments · May be fixed by #128
Labels
investigating Investigating.

Comments

@PMunch
Copy link

PMunch commented Sep 2, 2024

In the IRC <-> Discord bridge messageUpdate is used to send diff'ed messages to IRC when a message on Discord is edited. Currently whenever the messageUpdate callback is called the message in old and the new message are the same, meaning no update message is sent. The current flow for this is here: https://github.com/nimbackup/ircord/blob/master/src/ircord.nim#L487. I'm not sure if this is an issue in the ircord bot or in this library, but the code in the bot hasn't changed in a long time, so I think it's either in this repository or on Discords servers.
@ire4ever1190 ire4ever1190 linked a pull request Sep 2, 2024 that will close this issue
Open
@krisppurg
Copy link
Owner

For this case, it commonly happens when someone sends links that contain embeds. When a link is posted, the message automatically gets updated to add in the embed afterwards but on the client it does not have the (edited) label.
Content is always the same when thats the case since only embed is added to that message containing the link automatically.

@PMunch
Copy link
Author

PMunch commented Sep 2, 2024

I was just testing with normal messages and editing them myself. No links or anything.

@krisppurg
Copy link
Owner

I was just testing with normal messages and editing them myself. No links or anything.

hm, could you show me the data comparison between the old one and the new one?

just go to the source code and edit the following just before the checkandcall line

@krisppurg krisppurg added the investigating Investigating. label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigating Investigating.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't update message in cache by reference ire4ever1190/dimscord
2 participants
@PMunch @krisppurg