New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] height off-by-one bug? #34

Closed

hartwork opened this issue Nov 5, 2019 · 1 comment

Assignees

Labels

hartwork commented Nov 5, 2019

This looks like an off-by-one bug for height — can you confirm?

In [9]: print(asciichartpy.plot([0, 0, 1, 2], {'height': 1}))
    2.00  ┼  ╭ 
    0.00  ┼──╯ 

In [10]: print(asciichartpy.plot([0, 0, 1, 2], {'height': 2}))
    2.00  ┼  ╭ 
    1.00  ┤ ╭╯ 
    0.00  ┼─╯  

In [11]: print(asciichartpy.plot([0, 0, 1, 2], {'height': 5}))
    2.00  ┼  ╭ 
    1.60  ┤  │ 
    1.20  ┤  │ 
    0.80  ┤ ╭╯ 
    0.40  ┤ │  
    0.00  ┼─╯

The text was updated successfully, but these errors were encountered:

kroitor self-assigned this

Owner

kroitor commented Nov 5, 2019 •

edited

Loading

@hartwork yep, check this out:

I suggest to move this discussion there )

kroitor added the duplicate label

kroitor closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment