Interface for Model Workflow

[wit3]

Hi

When custom model it's defined the entire package continue to reference in php doc to the "base" workflow model in phpdocblock use Workflow class
like here

venture/src/WorkflowDefinition.php

Line 164 in c0912c8

* @param callable(Workflow): void $callback

this create an error with phpstan beacause doesn't accept the new defined model ( that extend Workflow as described in readme )

Maybe an interface it's a solution?

[ksassnowski]

Weird, as passing in a class that extends from Workflow should still be covariant. I'm a bit surprised PHPStan complains about that.

[wit3]

My custom model is a plain class that extend Workflow

<?php

namespace App\Models;


use Sassnowski\Venture\Models\Workflow as VentureWorkflow;


class Workflow extends VentureWorkflow
{
    
}

this is the error in phpstan

[ksassnowski]

Ok, I'm able to reproduce this and understand what the issue is. Unfortunately, it looks like this is not something I can fix before this PR gets merged into PHPStan phpstan/phpstan-src#1835. So for now, you'll have to add that error to your baseline.

[wit3]

No probleme dude 👍