Unable to add jobs with integer ID's - Call to a member function getID() on int

[stevebauman]

I've discovered that we're not able to add jobs with integer based ID's, as they will not be recognized as a "static dependency" here in mapDependencies():

venture/src/WorkflowDefinition.php

Lines 454 to 467 in 73cdd0f

	private function mapDependencies(array $dependencies): array
	{
	$result = [];
	foreach ($dependencies as $dependency) {
	if (\is_string($dependency)) {
	$dependency = new StaticDependency($dependency);
	}
	$result[] = $dependency;
	}
	return $result;
	}

To reproduce, add a job with an integer based dependency, then make a job depend on it:

$workflow = $this->define('Some workflow'):

$workflow->addJob(
    job: new SomeJob(),
    id: 1,
);

// throws Exception: Error: Call to a member function getID() on int
$workflow->addJob(
    job: new SomeOtherJob(),
    dependencies: [1],
);

Should we do one of the below?

• Allow integer dependencies
• Throw an exception if this is attempted
• Cast job IDs to a string if it is an integer