Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Error when trying to display XDA Developers categories #43

Open
XploreInfinity opened this issue Sep 14, 2024 · 1 comment
Open

Comments

@XploreInfinity
Copy link

XploreInfinity commented Sep 14, 2024

To reproduce:
Go to subscriptions -> Select XDA Developers (under the technology category) -> See the error message "Null check operator used on a null value"

Android version: 11
App version: 0.14.0

Cause: Occurs because the getter categories in lib/extractor/technology/xdadevelopers.dart looks for elements with class name sidenav-link and accesses their href attribute without checking if it exists.

Fix: I tried adding a check that prevents the null value from being passed on to the categories Map, and it works as expected.

I didn't immediately create a PR because the fix is quite small, and there seems to be some problem with tests on my environment. Let me know if you need any help, thanks : )

@ksh-b
Copy link
Owner

ksh-b commented Sep 21, 2024

Thanks, should be fixed in next version. This affects androidpolice too I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants