New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Length check based on `String.lenght/1` is not safe for `info_hash` #40

Open

mogeko opened this issue Jan 6, 2023 · 0 comments

Labels

bug

Collaborator

mogeko commented Jan 6, 2023

<<134, 145, 65, 194, 112, 216, 176, 136, 44, 184, 247, 245, 170, 31, 137, 120, 193, 96, 57, 114>> is a legal info_hash.

But String.lenght/1 thinks its length is 19.

iex> <<134, 145, 65, 194, 112, 216, 176, 136, 44, 184, 247, 245, 170, 31, 137, 120, 193, 96, 57, 114>>
...> |> String.length
19

The text was updated successfully, but these errors were encountered:

mogeko added the bug label

mogeko added a commit that referenced this issue


          fix: remove the check of info_hash & peer_id length

984ca3a

Issue #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment