Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesClientConfiguration.JsonSerializerOptions always returns null. #1598

Open
davidivkovic opened this issue Nov 24, 2024 · 5 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@davidivkovic
Copy link

Describe the bug
KubernetesClientConfiguration.JsonSerializerOptions always returns null.

The getter for this property calls the KubernetesJson.AddJsonOptions method which is empty.

public JsonSerializerOptions JsonSerializerOptions
{
get
{
// If not yet set, use defaults from KubernetesJson.
if (jsonSerializerOptions is null)
{
KubernetesJson.AddJsonOptions(options =>
{
jsonSerializerOptions = new JsonSerializerOptions(options);
});
}
return jsonSerializerOptions;
}
private set => jsonSerializerOptions = value;
}

public static void AddJsonOptions(Action<JsonSerializerOptions> configure)
{
}

Kubernetes C# SDK Client Version
KubernetesClient.Aot 15.0.1

Server Kubernetes Version
1.30.2

Dotnet Runtime Version
.net9

To Reproduce
Create a KubernetesClientConfiguration and call the JsonSerializerOptions property.

Expected behavior
A System.Text.Json.JsonSerializerOptions instance to be returned.

Where do you run your app with Kubernetes SDK (please complete the following information):
Linux

@tg123
Copy link
Member

tg123 commented Nov 25, 2024

aot should not expose this prop as you can't config it

@davidivkovic
Copy link
Author

Is it possible to register a serializer context for custom types used with client.CustomObjects.CreateNamespacedCustomObjectWithHttpMessagesAsync(customObject)?

@tg123
Copy link
Member

tg123 commented Nov 25, 2024

it is not possible in aot
everything is compiled ahead of time, no dynamic code allowed in this mode

if the main sdk good for you, aot is for performance scenarios only

@davidivkovic
Copy link
Author

So it's currently not possible to use the CreateNamespacedCustomObject method in AOT?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants