Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an AppArmor profile for the operator #169

Closed
wants to merge 1 commit into from
Closed

Create an AppArmor profile for the operator #169

wants to merge 1 commit into from

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Dec 14, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

Limits the execution powers of the operator, decreasing its attack surface.

Which issue(s) this PR fixes:

Fixes #65

Special notes for your reviewer:

This is an initial profile, however this blocked by kubernetes/kubernetes#97273.

Does this PR introduce a user-facing change?

/hold

@k8s-ci-robot
Copy link
Contributor

@pjbgf: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjbgf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 14, 2020
@pjbgf
Copy link
Member Author

pjbgf commented Dec 14, 2020

We may need to try to find a different approach for deploying the operator's own profiles.
Given that the break-out of a single operator into separate deploy-able components may be a good opportunity to review this.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 14, 2020
@k8s-ci-robot
Copy link
Contributor

@pjbgf: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-security-profiles-operator-test-e2e e064ecf link /test pull-security-profiles-operator-test-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

@pjbgf: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2020
@pjbgf
Copy link
Member Author

pjbgf commented Feb 4, 2021

@saschagrunert what are your thoughts on this one? Shall we just leave it here until at least kubernetes/kubernetes#97966 is merged?

@saschagrunert
Copy link
Member

@saschagrunert what are your thoughts on this one? Shall we just leave it here until at least kubernetes/kubernetes#97966 is merged?

I assume it does not have any bad implications for older Kubernetes versions, right? If so, then I'd propose we move forward, rebase and get this in :)

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 6, 2021
@pjbgf
Copy link
Member Author

pjbgf commented May 18, 2021

I assume it does not have any bad implications for older Kubernetes versions, right? If so, then I'd propose we move forward, rebase and get this in :)

@saschagrunert I don't think there would be. But given that the upstream issue is a bit stuck, I will close this issue and may reopen it once we are in a better position.

@pjbgf pjbgf closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmurphy cmurphy Awaiting requested review from cmurphy

@hasheddan hasheddan Awaiting requested review from hasheddan

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create AppArmor profile for the operator
4 participants
@pjbgf @k8s-ci-robot @saschagrunert @fejta-bot