Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PART-2]vsan stretch testcase automation for TKG, WCP and VMService VMs #3020

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[PART-2]vsan stretch testcase automation for TKG, WCP and VMService VMs #3020

wants to merge 1 commit into from

Conversation

Aishwarya-Hebbar
Copy link
Contributor

@Aishwarya-Hebbar Aishwarya-Hebbar commented Sep 2, 2024 •
edited
Loading

What this PR does / why we need it: vsan stretch testcase automation for TKG, WCP and VMService VMs

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
Will update in sometime

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Aishwarya-Hebbar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 2, 2024
@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the vsan_stretch_tc_p1 branch 3 times, most recently from 12b6d7b to 0caf5b5 Compare September 5, 2024 07:30
@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 80

@svcbot-qecnsdp
Copy link 

Build ID: 80
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
./vsan_stretched_cluster.go:4659:45: undefined: dep2ReplicaCount
./vsan_stretched_cluster.go:4659:45: too many errors


Ginkgo ran 1 suite in 45.510108006s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/kai_vsan_stretch_tkg_precheckin/Results/80/vsphere-csi-driver`

@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 81

@svcbot-qecnsdp
Copy link 

Build ID: 81
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 2 Failed | 0 Pending | 888 Skipped
--- FAIL: TestE2E (3008.79s)
FAIL

Ginkgo ran 1 suite in 51m18.917461519s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/kai_vsan_stretch_tkg_precheckin/Results/81/vsphere-csi-driver`

@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the vsan_stretch_tc_p1 branch 2 times, most recently from 6eed74e to 8c5cc68 Compare September 5, 2024 12:10
@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 82

@svcbot-qecnsdp
Copy link 

Build ID: 82
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 889 Skipped
--- FAIL: TestE2E (2631.29s)
FAIL

Ginkgo ran 1 suite in 45m21.547558625s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/kai_vsan_stretch_tkg_precheckin/Results/82/vsphere-csi-driver`

@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 83

@svcbot-qecnsdp
Copy link 

Build ID: 83
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 889 Skipped
--- FAIL: TestE2E (4944.69s)
FAIL

Ginkgo ran 1 suite in 1h23m49.474781702s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/kai_vsan_stretch_tkg_precheckin/Results/83/vsphere-csi-driver`

@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the vsan_stretch_tc_p1 branch 3 times, most recently from e88a301 to 2b8e8c2 Compare September 6, 2024 12:01
@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 84

@svcbot-qecnsdp
Copy link 

Build ID: 84
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 889 Skipped
--- FAIL: TestE2E (4928.25s)
FAIL

Ginkgo ran 1 suite in 1h23m22.487486494s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/kai_vsan_stretch_tkg_precheckin/Results/84/vsphere-csi-driver`

@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the vsan_stretch_tc_p1 branch 2 times, most recently from cf78fa5 to 59d0a77 Compare September 7, 2024 15:49
@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 138

@svcbot-qecnsdp
Copy link 

Build ID: 138
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 889 Skipped
--- FAIL: TestE2E (2730.75s)
FAIL

Ginkgo ran 1 suite in 46m30.72455435s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/kai_vsan_stretch_tkg_precheckin/Results/138/vsphere-csi-driver`

@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 139

@svcbot-qecnsdp
Copy link 

Build ID: 139
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 889 Skipped
--- FAIL: TestE2E (2795.00s)
FAIL

Ginkgo ran 1 suite in 47m31.376190359s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/kai_vsan_stretch_tkg_precheckin/Results/139/vsphere-csi-driver`

@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 140

@svcbot-qecnsdp
Copy link 

Build ID: 140
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 889 Skipped
--- FAIL: TestE2E (2267.24s)
FAIL

Ginkgo ran 1 suite in 38m44.95041972s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/kai_vsan_stretch_tkg_precheckin/Results/140/vsphere-csi-driver`

@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 141

@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 142

@svcbot-qecnsdp
Copy link 

Build ID: 142
GC build status: FAILURE 
Stage before exit: e2e-tests

@svcbot-qecnsdp
Copy link 

Build ID: 141
GC build status: SUCCESS 
Stage before exit: finally 
Jenkins E2E Test Results: 

Ran 0 of 890 Specs in 0.017 seconds
SUCCESS! -- 0 Passed | 0 Failed | 0 Pending | 890 Skipped
PASS

Ginkgo ran 1 suite in 57.329653719s
Test Suite Passed
make: Leaving directory `/home/worker/workspace/kai_vsan_stretch_tkg_precheckin/Results/141/vsphere-csi-driver`

@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the vsan_stretch_tc_p1 branch 2 times, most recently from 4df2150 to fc3b3aa Compare September 16, 2024 17:43
@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 14

@svcbot-qecnsdp
Copy link 

Build ID: 14
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 889 Skipped
--- FAIL: TestE2E (2727.51s)
FAIL

Ginkgo ran 1 suite in 46m38.043337911s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/kai_vsan_stretch_tkg_file_precheckin/Results/14/vsphere-csi-driver`

@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 15

@svcbot-qecnsdp
Copy link 

Build ID: 15
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 889 Skipped
--- FAIL: TestE2E (30.33s)
FAIL

Ginkgo ran 1 suite in 1m44.174917279s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/kai_vsan_stretch_tkg_file_precheckin/Results/15/vsphere-csi-driver`

@svcbot-qecnsdp
Copy link

Started GC block pre-checkin pipeline... Build Number: 16

@svcbot-qecnsdp
Copy link 

Build ID: 16
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 889 Skipped
--- FAIL: TestE2E (30.42s)
FAIL

Ginkgo ran 1 suite in 1m49.090359441s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/kai_vsan_stretch_tkg_file_precheckin/Results/16/vsphere-csi-driver`

@Aishwarya-Hebbar Aishwarya-Hebbar changed the title [WIP] [PART-2]vsan stretch testcase automation for TKG, WCP and VMService VMs [PART-2]vsan stretch testcase automation for TKG, WCP and VMService VMs Nov 21, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
rajguptavm
rajguptavm reviewed Nov 22, 2024
View reviewed changes
tests/e2e/vsan_stretched_cluster_utils.go
},
HostKeyCallback: ssh.InsecureIgnoreHostKey(),
}

cmd := "export GOVC_INSECURE=1;"
cmd += fmt.Sprintf("export GOVC_URL='https://[email protected]:%s@%s';",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this hardcoded value

rajguptavm
rajguptavm approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@rajguptavm rajguptavm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with minor comment & add results

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aishwarya-Hebbar, rajguptavm
Once this PR has been reviewed and has the lgtm label, please assign sipriyaa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kavyashree-r
kavyashree-r reviewed Nov 22, 2024
View reviewed changes
tests/e2e/vm_service_vsan_stretch_cluster.go
defer func() {
ginkgo.By("Deleting VM bootstrap data")
err := client.CoreV1().Secrets(namespace).Delete(ctx, secretName, *metav1.NewDeleteOptions(0))
time.Sleep(5 * time.Minute)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use "pollTimeout"

tests/e2e/vm_service_vsan_stretch_cluster.go
gomega.Expect(err).NotTo(gomega.HaveOccurred())
}

time.Sleep(5 * time.Minute)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use "pollTimeout" in all the wait time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavyashree-r kavyashree-r kavyashree-r left review comments

@rajguptavm rajguptavm rajguptavm approved these changes

@sipriyaa sipriyaa Awaiting requested review from sipriyaa

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Aishwarya-Hebbar @k8s-ci-robot @svcbot-qecnsdp @kavyashree-r @rajguptavm