Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values for NodeSelectorTerms are evaluated asynchronously #184

Open
JamesGAWS opened this issue Oct 15, 2024 · 0 comments
Open

Values for NodeSelectorTerms are evaluated asynchronously #184

JamesGAWS opened this issue Oct 15, 2024 · 0 comments

Comments

@JamesGAWS
Copy link

Currently for AWS Elastic Kubernetes Serivce it is possible to create a deployment with the following spec:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: inflate
spec:
  replicas: 1
  selector:
    matchLabels:
      app: inflate
  template:
    metadata:
      labels:
        app: inflate
    spec:
      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
            - matchExpressions:
              - key: "eks.amazonaws.com/nodegroup"
                operator: In
                values:
                - "${INVALID_VALUE}"
      terminationGracePeriodSeconds: 0
      securityContext:
        runAsUser: 1000
        runAsGroup: 3000
        fsGroup: 2000
      containers:
      - name: inflate
        image: public.ecr.aws/eks-distro/kubernetes/pause:3.7
        resources:
          requests:
            cpu: 1
        securityContext:
          allowPrivilegeEscalation: false

Despite the presence of invalid characters in the nodeSelectorTerms value, the API server will accept this payload. During scheduling, the label value is validated which the label will fail since it contains invalid characters.

Typical behavior for invalid characters is for the apply call to fail synchronously. Why is this field different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant