Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest ko #1064

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Update to latest ko #1064

merged 1 commit into from
Nov 25, 2024

Conversation

cartermckinnon
Copy link
Contributor

@cartermckinnon cartermckinnon commented Nov 25, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

CI jobs are broken because we were using an ancient version of google/ko that has a broken dependency chain:

> make ko-build-local
hack/install-ko.sh
go: downloading github.com/google/ko v0.11.2
go: github.com/google/[email protected]: version constraints conflict:
	github.com/google/[email protected] indirectly requires nhooyr.io/[email protected]: reading nhooyr.io/websocket/go.mod at revision v1.8.7: unknown revision v1.8.7

Results in:

 Error response from daemon: No such image: ko.local:v1.30.0-beta.0-110-gac63fea
The push refers to repository [209411653980.dkr.ecr.us-east-1.amazonaws.com/provider-aws/cloud-controller-manager]
An image does not exist locally with the tag: 209411653980.dkr.ecr.us-east-1.amazonaws.com/provider-aws/cloud-controller-manager 

See: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/cloud-provider-aws/1060/pull-cloud-provider-aws-e2e-kubetest2-quick/1861104799588552704

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 25, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2024
@mmerkes
Copy link
Contributor

mmerkes commented Nov 25, 2024

/lgtm

Will approve when the CI completes successfully.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@cartermckinnon
Copy link
Contributor Author

@mmerkes I don't think this will get it green, but it's one problem that needs fixing 😄

@dims
Copy link
Member

dims commented Nov 25, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@dims
Copy link
Member

dims commented Nov 25, 2024

/hold

until ready to land

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2024
@cartermckinnon
Copy link
Contributor Author

This depends on: kubernetes/test-infra#33844

@cartermckinnon
Copy link
Contributor Author

/retest

@cartermckinnon
Copy link
Contributor Author

@mmerkes we're green! can you lgtm and remove the hold?

@mmerkes
Copy link
Contributor

mmerkes commented Nov 25, 2024

/remove-hold
/lgtm
/approve

Tx for fixing!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mmerkes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e58b027 into kubernetes:master Nov 25, 2024
13 checks passed
@cartermckinnon cartermckinnon deleted the fix-ci branch November 25, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants