-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest ko #1064
Update to latest ko #1064
Conversation
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm Will approve when the CI completes successfully. |
@mmerkes I don't think this will get it green, but it's one problem that needs fixing 😄 |
/approve |
6e3c716
to
f703513
Compare
/hold until ready to land |
f703513
to
f726030
Compare
This depends on: kubernetes/test-infra#33844 |
/retest |
@mmerkes we're green! can you lgtm and remove the hold? |
/remove-hold Tx for fixing! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, mmerkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
CI jobs are broken because we were using an ancient version of
google/ko
that has a broken dependency chain:Results in:
See: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/cloud-provider-aws/1060/pull-cloud-provider-aws-e2e-kubetest2-quick/1861104799588552704
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: