-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): remove kong configuration if kong disabled in values #9320
Conversation
remove-configmap-if-kong-disabled
Welcome @bear-san! |
FWIW: The same change is added to this PR which allows kong to be disabled and still get an ingress. #9317 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. It does not make sense to create this CM when kong is disabled. Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bear-san, floreks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9320 +/- ##
==========================================
- Coverage 37.22% 37.21% -0.01%
==========================================
Files 255 255
Lines 11197 11197
Branches 142 142
==========================================
- Hits 4168 4167 -1
- Misses 6810 6811 +1
Partials 219 219 |
This change aims to remove unnecessary configuration if Kong subchart disabled by Helm Chart values.
I have inserted condition to ConfigMap, that requires
.Values.kong.enabled
set totrue
.