Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split L3 Cache Topology Awareness in CPU Manager #5109

Open
1 of 4 tasks
ajcaldelas opened this issue Jan 30, 2025 · 14 comments
Open
1 of 4 tasks

Split L3 Cache Topology Awareness in CPU Manager #5109

ajcaldelas opened this issue Jan 30, 2025 · 14 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@ajcaldelas
Copy link
Contributor

ajcaldelas commented Jan 30, 2025

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 30, 2025
@ajcaldelas
Copy link
Contributor Author

ajcaldelas commented Jan 30, 2025

/sig node
/assign @ajcaldelas @wongchar

@k8s-ci-robot
Copy link
Contributor

@ajcaldelas: The label(s) sig/sig-node cannot be applied, because the repository doesn't have them.

In response to this:

/sig sig-node
/assign @ajcaldelas @wongchar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@ajcaldelas: GitHub didn't allow me to assign the following users: wongchar.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/sig sig-node
/assign @ajcaldelas @wongchar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kannon92
Copy link
Contributor

I don't understand why #4800 is not sufficient.

Is this a duplicate?

@ajcaldelas
Copy link
Contributor Author

I don't understand why #4800 is not sufficient.

Is this a duplicate?

From what I understand since the original author is no longer contributing atm, we need to create a new issue and backlink the original issue. This is not a duplicate in that sense, I mentioned a reference to it in the issue description.

@ffromani if you could chime in that would be appreciated.

@ffromani
Copy link
Contributor

I don't understand why #4800 is not sufficient.

Is this a duplicate?

this is another case on which we have to adopt an issue because AFAIU the original contributor is no longer active and someone else is taking over.
The current approach (which I suggested indeed offline) seems the less bad to me but I'm open to suggestions.

@ffromani
Copy link
Contributor

started a thread on sig-arch to see if we can improve this take-over process https://kubernetes.slack.com/archives/C5P3FE08M/p1738311284411229

@ffromani
Copy link
Contributor

/sig node

please review examples of other takeovers. Examples (there are others):
#3570
#3743

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 31, 2025
@kannon92
Copy link
Contributor

Taking over this is fine. It wasn't clear in the description.

Can you make sure the KEP template follows others? The markdown seems off.

@ajcaldelas
Copy link
Contributor Author

Can you be specific? I directly copied it from the repo so I'm not sure what's off about it

@kannon92
Copy link
Contributor

kannon92 commented Jan 31, 2025

#4800 looks different than yours.

It is the markdown formatting that differs not the content but let's try to be consistent.

@wongchar
Copy link
Contributor

/assign @wongchar

@haircommander
Copy link
Contributor

/label lead-opted-in
/milestone v1.33

note: PRR freeze is tomorrow! you need to have a KEP update for this opened before then. Thanks!

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 5, 2025
@jenshu
Copy link

jenshu commented Feb 7, 2025

Hello @wongchar, @ajcaldelas 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • in the kep.yaml, the latest-milestone should be updated to v1.33 (I see that you have a PR open that will take care of that)

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@jenshu jenshu moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 7, 2025
@jenshu jenshu added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: At risk for enhancements freeze
Status: Proposed for consideration
Development

No branches or pull requests

7 participants