Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube_pod_scheduler and kube_pod_service_account should not be separate metrics #2549

Open
brancz opened this issue Nov 7, 2024 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@brancz
Copy link
Member

brancz commented Nov 7, 2024

What would you like to be added:

kube_pod_scheduler and kube_pod_service_account should not be separate metrics, they should each be labels of the _info metric.

Why is this needed:

There is no cardinality increase by adding labels that will never change over the pod's lifetime, however, having both of these metrics separately, causes a cardinality increase by the number of pods (2x of course since they are two metrics).

Describe the solution you'd like

Add scheduler and service account to the info metric.

Additional context

n/a

@brancz brancz added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 7, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrueg
Copy link
Member

mrueg commented Nov 7, 2024

Agreeing, we currently try to document best practices here: #2528 and then as a next step work on reimplementing the metrics for a v3. Feel free to provide some feedback in the PR if you have some cycles. :)

@brancz
Copy link
Member Author

brancz commented Nov 7, 2024

v3 sounds great!

Any reason not to change this for kube_pod_scheduler and kube_pod_service_account now? They are both alpha metrics.

Happy to create the PR!

@mrueg
Copy link
Member

mrueg commented Nov 8, 2024

Yes I think we can merge them in, feel free to create the PR :)

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

4 participants