kube_pod_scheduler and kube_pod_service_account should not be separate metrics

[brancz]

What would you like to be added:

kube_pod_scheduler and kube_pod_service_account should not be separate metrics, they should each be labels of the _info metric.

Why is this needed:

There is no cardinality increase by adding labels that will never change over the pod's lifetime, however, having both of these metrics separately, causes a cardinality increase by the number of pods (2x of course since they are two metrics).

Describe the solution you'd like

Add scheduler and service account to the info metric.

Additional context

n/a

[k8s-ci-robot]

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mrueg]

Agreeing, we currently try to document best practices here: #2528 and then as a next step work on reimplementing the metrics for a v3. Feel free to provide some feedback in the PR if you have some cycles. :)

[brancz]

v3 sounds great!

Any reason not to change this for kube_pod_scheduler and kube_pod_service_account now? They are both alpha metrics.

Happy to create the PR!

[mrueg]

Yes I think we can merge them in, feel free to create the PR :)