Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Botkube CLI sometimes doesn't stream logs on install/update #1152

Open
pkosiec opened this issue Jul 17, 2023 · 0 comments
Open

Botkube CLI sometimes doesn't stream logs on install/update #1152

pkosiec opened this issue Jul 17, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@pkosiec
Copy link
Collaborator

pkosiec commented Jul 17, 2023 •
edited
Loading

Description

As reported here #1148 (review):

I noticed sometimes we don't show the logs when we do actual upgrade (which recreates the pod during actual upgrade). See the video for details - looks like a race condition issue.

Expected behavior

Botkube CLI always streams logs

Actual behavior

No logs at all

Steps to reproduce

Try a few times the following steps - upgrade Botkube with CLI a few times with changed configuration:

See the video: https://github.com/kubeshop/botkube/assets/7155799/639aae23-0f50-4844-82b8-3df1d32c2b3b

AC

  • Fix the streaming issue on the update
  • On install/upgrade failure, wait for 2-3 Pod restarts before showing installtion/upgrade failure

(troubleshooting link is there in the output message, so nothing to do in this area for now)
@pkosiec pkosiec added the bug Something isn't working label Jul 17, 2023
@pkosiec pkosiec added this to the v1.3.0 milestone Jul 17, 2023
@pkosiec pkosiec added this to Botkube Jul 17, 2023
@pkosiec pkosiec moved this to Todo in Botkube Jul 17, 2023
@pkosiec pkosiec added the needs-triage Relates to issues that should be refined label Jul 17, 2023
@pkosiec pkosiec modified the milestones: v1.3.0, v1.4.0 Jul 18, 2023
@pkosiec pkosiec removed the status in Botkube Aug 16, 2023
@pkosiec pkosiec modified the milestones: v1.4.0, v1.5.0 Aug 16, 2023
@pkosiec pkosiec modified the milestones: v1.5.0, v1.4.0, v1.6.0 Sep 12, 2023
@pkosiec pkosiec removed the needs-triage Relates to issues that should be refined label Sep 12, 2023
@pkosiec pkosiec moved this to Todo in Botkube Sep 12, 2023
@mszostok mszostok self-assigned this Oct 2, 2023
@mszostok mszostok moved this from Todo to In Progress in Botkube Oct 2, 2023
@mszostok mszostok moved this from In Progress to Todo in Botkube Oct 4, 2023
@mszostok mszostok removed their assignment Oct 4, 2023
@pkosiec pkosiec modified the milestones: v1.5.0, v1.6.0 Oct 10, 2023
@pkosiec pkosiec modified the milestones: v1.6.0, v1.7.0 Nov 21, 2023
@pkosiec pkosiec removed the status in Botkube Nov 21, 2023
@pkosiec pkosiec changed the title Botkube CLI sometimes doesn't stream logs on update Botkube CLI sometimes doesn't stream logs on install/update Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Botkube
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkosiec @mszostok