-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiarch fakeovirt-image #3519
Comments
TBH I have never heard of that image. @mrnold @machacekondra can you help out here? |
@awels do you happen to know where that image comes from? |
Hm, it seems to come from this repo: https://github.com/machacekondra/fakeovirt |
IIRC I created a container from that repo a long time ago, I forget the details. I would have to go through the git logs to see the details. |
From what I can recall this was just a copy of machacekondra/fakeovirt:test from Dockerhub. I don't think I ended up needing any changes to the image. |
I think it should support multi arch just fine. Is there any action needed from me? |
Probably just need to create the actual containers for multi arch. |
I just write a script to build the multi-arch fakeovirt image, I can run it successfully on my loacl x86 server.
|
@zhlhahaha would it make sense to transfer the repo to kubevirt org? Then we could store the script inside it and create a prowjob that creates/updates the image whenever changes occur? Also we'd just push it to quay.io/kubevirtci or quay.io/kubevirt? |
"Someone" would then need to maintain it though. @awels would you know any takers on the maintenance? |
I can own it. There have not been many changes to this so it should be pretty easy to maintain. |
Hi @dhiller,
Yes, I think so, as there is no script for build multi-arch image in the original repo, we need to do it by ourselves.
I think quay.io/kubevirtci is good as the image is only need in the CI/CD tests? @awels How do you think? |
It is actually only needed in CDI tier1 tests. Nothing else uses it. So it makes sense to have it in the CDI repo. |
The image
quay.io/kubevirt/fakeovirt:v1.38.0
inmanifests/templates/imageio.yaml.in
which only supports x86_64. We may need to make it support multi-arch.@brianmcarey @dhiller I did not see any jobs for releasing the image, is the image copy from dockerhub?
The text was updated successfully, but these errors were encountered: