fix: add group annotation to WebhookConfiguration and filter watch requests #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
fix/filter-group-related-webhook-watch
branch
from
fb9fe8a
to
5f31d06
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
==========================================
+ Coverage 70.44% 70.53% +0.09%
==========================================
Files 30 30
Lines 2551 2559 +8
==========================================
+ Hits 1797 1805 +8
Misses 584 584
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvanz
approved these changes
Sep 23, 2024
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
flavio
reviewed
Sep 23, 2024
Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
fix/filter-group-related-webhook-watch
branch
from
9797513
to
03aff9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a group annotation to ValidatingWebhookConfiguration and MutatingWebhookConfiguration for policy groups, enabling us to filter watch requests sent to the respective reconcilers.