Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move linking to frontend #135

Open
SOF3 opened this issue Jul 21, 2023 · 0 comments
Open

Move linking to frontend #135

SOF3 opened this issue Jul 21, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@SOF3
Copy link
Member

SOF3 commented Jul 21, 2023

Description

Instead of finding the trace as the linker, the aggregator just emits a tag that indicates the CGRNN of the parent span. Children are emitted with a separate trace ID so that each object has its own trace.

To be precise, we can remove the "parent"/"child" relationship in general and emit a new pseudospan type called "link":

tag name tag value
zzz-traceSource "link"
linkedCluster linked object cluster
linkedGroup linked object group
linkedResource linked object resource
linkedNamespace linked object namespace
linkedName linked object name
linkedRole If "parent", the current span is displayed as a child of the linked span. If empty, the linked span is displayed as a child of the current span. Otherwise, the linked span is displayed under a display-only virtual span with the specified role

User story

Currently, frontend queries that use the exclusive mode have to search the entire trace, making queries unnecessarily slow. Since the user may only be interested in a particular object, we can speed up the query by limiting each trace to one object only.

This allows us to use more aggressive linkers, which may become more significant with #109. Furthermore, dynamic linking means that we can now have multi-object links, such as linking pods to their secrets/nodes (this was previously not possible because nodes can relate to multiple pods).

@SOF3 SOF3 added the enhancement New feature or request label Jul 21, 2023
SOF3 added a commit that referenced this issue Sep 19, 2023
Implement #135: Move linking to frontend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant