Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clause parse error reporting #124

Open
kubukoz opened this issue Oct 16, 2022 · 0 comments
Open

Use clause parse error reporting #124

kubukoz opened this issue Oct 16, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@kubukoz
Copy link
Owner

kubukoz commented Oct 16, 2022

Following changes from #119 (or maybe it was the case even before), error reporting in use clauses is now pretty confusing:

image

Same goes for qualified operation names:

image

I think it's most likely caused by the backtracking in .soft (so it would've been like this even before #119 after all). A proper fix would probably involve removing the backtracking in Parser[QualifiedIdentifier]:

https://github.com/kubukoz/smithy-playground/blob/main/modules/parser/src/main/scala/playground/smithyql/parser/Parser.scala#L150-L167

and replacing that parser's occurrences with something more usecase-driven (i.e. in operation names, read one segment and then decide what we're actually parsing).

@kubukoz kubukoz added the bug Something isn't working label Oct 16, 2022
@kubukoz kubukoz mentioned this issue Oct 16, 2022
2 tasks
@kubukoz kubukoz changed the title Use clause error reporting Use clause parse error reporting Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant