Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Console with a logger #154

Open
kubukoz opened this issue Mar 29, 2021 · 1 comment
Open

Replace Console with a logger #154

kubukoz opened this issue Mar 29, 2021 · 1 comment

Comments

@kubukoz
Copy link
Owner

kubukoz commented Mar 29, 2021

Having a logger would allow us to customize the levels of information being logged in debug/production mode more easily. We already have logback and slf4j in the dependencies because http4s brings them.

I think for the time being (while http4s is pulling in these logging libraries) the best course of action is to follow what we did in https://github.com/pitgull/pitgull: use https://github.com/valskalla/odin with an slf4j bridge.

If odin is to be used, that's blocked by its migration to Cats Effect 3. We also need to upgrade all other deps here to CE3 final before that happens: this would be just http4s and decline-effect.

@kubukoz
Copy link
Owner Author

kubukoz commented Apr 12, 2021

This will now be much easier now that UserOutput exists. I think it can log directly to console (or console and debug level to file), but any other usages of Console should be loggers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant