Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail PR checks on broken internal links #233

Open
porridge opened this issue Apr 2, 2020 · 0 comments
Open

Fail PR checks on broken internal links #233

porridge opened this issue Apr 2, 2020 · 0 comments
Assignees
@meichstedt
Labels
enhancement New feature or request

Comments

@porridge
Copy link
Member

porridge commented Apr 2, 2020

What would you like to be added:

A GitHub required check that prevents merging If there is a broken link that points within the kudo.dev site.

Why is this needed:

While #231 is a great improvement, it is easy to miss a mere warning:

  • there are some false-positives cloud the vision somewhat,
  • in a typical make docker-run the screen is automatically cleared soon after the warnings are shown, hiding them from view
  • there is no visibility into the warnings for a reviewer
@porridge porridge added the enhancement New feature or request label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meichstedt meichstedt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meichstedt @porridge