chore(deps): Bump @grafana from 8 to 9 #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
changed the title
|
Hi @lahabana , I tried to use https://www.npmjs.com/package/@grafana/create-plugin , it seems nice but add way too many files compared to what I was trying to do. Maybe you'll find it interesting ? |
|
Tried this create-plugin when started building this. It was way too limited for what we were doing and ended up not using it |
slonka
approved these changes
Dec 6, 2022
I had a look and don't see anything out of the ordinary, though actually assessing this functionality would require project familiarity and usage knowledge that I don't have. |
mmorel-35
changed the title
mmorel-35
changed the title
|
Any updates on this ? |
|
@mmorel-35 need to find time to double check the compatibility |
mmorel-35
changed the title
|
Any chance it might be addressed soon ? |
mmorel-35
requested review from
lobkovilya and
lukidzi
and removed request for
a team
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from 9.0 version, Grafana deprecates the use of Data source proxy calls by id in favor of Data source proxy calls
see https://grafana.com/docs/grafana/latest/developers/http_api/data_source/#data-source-proxy-calls-by-id
This changes the actual configuration of the kumahq-kuma-datasource, the property to use is now prometheusDataSourceUid instead of prometheusDataSourceId.
Thi also upgrades the @grafana dependencies to use 9.4.3 versions
Concerning the handleErrors function, I found it in https://github.com/grafana/grafana/tree/main/public/app/plugins/datasource/prometheus
Signed-off-by: Matthieu MOREL [email protected]