From aff103daf8f4e448fd63bb897f043a3e148285ee Mon Sep 17 00:00:00 2001 From: Kumaraswamy Vithanala <36370570+kumarvna@users.noreply.github.com> Date: Sun, 18 Jul 2021 18:59:54 +0530 Subject: [PATCH 1/2] updating examples for version 2.2.0 --- README.md | 13 +++++++++---- examples/README.md | 14 ++++++++++++-- examples/linux_vm_scale_sets/README.md | 7 ++++++- examples/linux_vm_scale_sets/main.tf | 7 ++++++- examples/windows_vm_scale_sets/README.md | 7 ++++++- examples/windows_vm_scale_sets/main.tf | 7 ++++++- versions.tf | 3 --- 7 files changed, 45 insertions(+), 13 deletions(-) diff --git a/README.md b/README.md index 5bc833a..a972c95 100644 --- a/README.md +++ b/README.md @@ -18,9 +18,14 @@ These types of resources supported: ## Module Usage ```hcl +# Azurerm provider configuration +provider "azurerm" { + features {} +} + module "vmscaleset" { source = "kumarvna/vm-scale-sets/azurerm" - version = "2.1.0" + version = "2.2.0" # Resource Group and location, VNet and Subnet detials (Required) resource_group_name = "rg-shared-westeurope-01" @@ -123,7 +128,7 @@ If the pre-defined Windows or Linux variants are not sufficient then, you can sp ```hcl module "vmscaleset" { source = "kumarvna/vm-scale-sets/azurerm" - version = "2.1.0" + version = "2.2.0" # .... omitted @@ -236,7 +241,7 @@ In the Source and Destination columns, `VirtualNetwork`, `AzureLoadBalancer`, an ```hcl module "vmscaleset" { source = "kumarvna/vm-scale-sets/azurerm" - version = "2.1.0" + version = "2.2.0" # .... omitted @@ -296,7 +301,7 @@ End Date of the Project|Date when this application, workload, or service is plan ```hcl module "vmscaleset" { source = "kumarvna/vm-scale-sets/azurerm" - version = "2.1.0" + version = "2.2.0" # Resource Group, location, VNet and Subnet details resource_group_name = "rg-hub-tieto-internal-shared-westeurope-001" diff --git a/examples/README.md b/examples/README.md index 48a97bb..532a2da 100644 --- a/examples/README.md +++ b/examples/README.md @@ -11,9 +11,14 @@ This module deploys Windows or Linux virtual machine scale sets with Public / Pr Following example creates Linux virtual machine scale sets with load balancer and auto scaling features. ```hcl +# Azurerm provider configuration +provider "azurerm" { + features {} +} + module "vmscaleset" { source = "kumarvna/vm-scale-sets/azurerm" - version = "2.1.0" + version = "2.2.0" # Resource Group and location, VNet and Subnet detials (Required) resource_group_name = "rg-shared-westeurope-01" @@ -95,9 +100,14 @@ module "vmscaleset" { Following example creates Windows virtual machine scale sets with load balancer and auto scaling features. ```hcl +# Azurerm provider configuration +provider "azurerm" { + features {} +} + module "vmscaleset" { source = "kumarvna/vm-scale-sets/azurerm" - version = "2.1.0" + version = "2.2.0" # Resource Group and location, VNet and Subnet detials (Required) resource_group_name = "rg-shared-westeurope-01" diff --git a/examples/linux_vm_scale_sets/README.md b/examples/linux_vm_scale_sets/README.md index b168415..e96fcc9 100644 --- a/examples/linux_vm_scale_sets/README.md +++ b/examples/linux_vm_scale_sets/README.md @@ -5,9 +5,14 @@ This module deploys Windows or Linux virtual machine scale sets with Public / Pr ## Module Usage ```hcl +# Azurerm provider configuration +provider "azurerm" { + features {} +} + module "vmscaleset" { source = "kumarvna/vm-scale-sets/azurerm" - version = "2.1.0" + version = "2.2.0" # Resource Group and location, VNet and Subnet detials (Required) resource_group_name = "rg-shared-westeurope-01" diff --git a/examples/linux_vm_scale_sets/main.tf b/examples/linux_vm_scale_sets/main.tf index 76edf12..d8ee8c3 100644 --- a/examples/linux_vm_scale_sets/main.tf +++ b/examples/linux_vm_scale_sets/main.tf @@ -1,6 +1,11 @@ +# Azurerm provider configuration +provider "azurerm" { + features {} +} + module "vmscaleset" { source = "kumarvna/vm-scale-sets/azurerm" - version = "2.1.0" + version = "2.2.0" # Resource Group and location, VNet and Subnet detials (Required) resource_group_name = "rg-shared-westeurope-01" diff --git a/examples/windows_vm_scale_sets/README.md b/examples/windows_vm_scale_sets/README.md index 2c50493..2b84161 100644 --- a/examples/windows_vm_scale_sets/README.md +++ b/examples/windows_vm_scale_sets/README.md @@ -5,9 +5,14 @@ This module deploys Windows or Linux virtual machine scale sets with Public / Pr ## Module Usage ```hcl +# Azurerm provider configuration +provider "azurerm" { + features {} +} + module "vmscaleset" { source = "kumarvna/vm-scale-sets/azurerm" - version = "2.1.0" + version = "2.2.0" # Resource Group and location, VNet and Subnet detials (Required) resource_group_name = "rg-shared-westeurope-01" diff --git a/examples/windows_vm_scale_sets/main.tf b/examples/windows_vm_scale_sets/main.tf index 65128af..ee26258 100644 --- a/examples/windows_vm_scale_sets/main.tf +++ b/examples/windows_vm_scale_sets/main.tf @@ -1,6 +1,11 @@ +# Azurerm provider configuration +provider "azurerm" { + features {} +} + module "vmscaleset" { source = "kumarvna/vm-scale-sets/azurerm" - version = "2.1.0" + version = "2.2.0" # Resource Group and location, VNet and Subnet detials (Required) resource_group_name = "rg-shared-westeurope-01" diff --git a/versions.tf b/versions.tf index 9403dfe..0761321 100644 --- a/versions.tf +++ b/versions.tf @@ -14,6 +14,3 @@ terraform { required_version = ">= 0.13" } -provider "azurerm" { - features {} -} From 38fbf6fb83ab5663b9519c4a35c423d6fb0f4937 Mon Sep 17 00:00:00 2001 From: Kumaraswamy Vithanala <36370570+kumarvna@users.noreply.github.com> Date: Sun, 18 Jul 2021 19:05:01 +0530 Subject: [PATCH 2/2] updating examples for version 2.2.0 --- README.md | 49 ++++--------------------------------------------- 1 file changed, 4 insertions(+), 45 deletions(-) diff --git a/README.md b/README.md index a972c95..d37376e 100644 --- a/README.md +++ b/README.md @@ -269,55 +269,14 @@ module "vmscaleset" { ## Recommended naming and tagging conventions -Well-defined naming and metadata tagging conventions help to quickly locate and manage resources. These conventions also help associate cloud usage costs with business teams via chargeback and show back accounting mechanisms. +Applying tags to your Azure resources, resource groups, and subscriptions to logically organize them into a taxonomy. Each tag consists of a name and a value pair. For example, you can apply the name `Environment` and the value `Production` to all the resources in production. +For recommendations on how to implement a tagging strategy, see Resource naming and tagging decision guide. -### Resource naming +>**Important** : +Tag names are case-insensitive for operations. A tag with a tag name, regardless of the casing, is updated or retrieved. However, the resource provider might keep the casing you provide for the tag name. You'll see that casing in cost reports. **Tag values are case-sensitive.** An effective naming convention assembles resource names by using important resource information as parts of a resource's name. For example, using these [recommended naming conventions](https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/naming-and-tagging#example-names), a public IP resource for a production SharePoint workload is named like this: `pip-sharepoint-prod-westus-001`. -> ### Metadata tags - -When applying metadata tags to the cloud resources, you can include information about those assets that couldn't be included in the resource name. You can use that information to perform more sophisticated filtering and reporting on resources. This information can be used by IT or business teams to find resources or generate reports about resource usage and billing. - -The following list provides the recommended common tags that capture important context and information about resources. Use this list as a starting point to establish your tagging conventions. - -Tag Name|Description|Key|Example Value|Required? ---------|-----------|---|-------------|---------| -Project Name|Name of the Project for the infra is created. This is mandatory to create a resource names.|ProjectName|{Project name}|Yes -Application Name|Name of the application, service, or workload the resource is associated with.|ApplicationName|{app name}|Yes -Approver|Name Person responsible for approving costs related to this resource.|Approver|{email}|Yes -Business Unit|Top-level division of your company that owns the subscription or workload the resource belongs to. In smaller organizations, this may represent a single corporate or shared top-level organizational element.|BusinessUnit|FINANCE, MARKETING,{Product Name},CORP,SHARED|Yes -Cost Center|Accounting cost center associated with this resource.|CostCenter|{number}|Yes -Disaster Recovery|Business criticality of this application, workload, or service.|DR|Mission Critical, Critical, Essential|Yes -Environment|Deployment environment of this application, workload, or service.|Env|Prod, Dev, QA, Stage, Test|Yes -Owner Name|Owner of the application, workload, or service.|Owner|{email}|Yes -Requester Name|User that requested the creation of this application.|Requestor| {email}|Yes -Service Class|Service Level Agreement level of this application, workload, or service.|ServiceClass|Dev, Bronze, Silver, Gold|Yes -Start Date of the project|Date when this application, workload, or service was first deployed.|StartDate|{date}|No -End Date of the Project|Date when this application, workload, or service is planned to be retired.|EndDate|{date}|No - -> This module allows you to manage the above metadata tags directly or as an variable using `variables.tf`. All Azure resources which support tagging can be tagged by specifying key-values in argument `tags`. Tag `ResourceName` is added automatically to all resources. - -```hcl -module "vmscaleset" { - source = "kumarvna/vm-scale-sets/azurerm" - version = "2.2.0" - - # Resource Group, location, VNet and Subnet details - resource_group_name = "rg-hub-tieto-internal-shared-westeurope-001" - - # ... omitted - - tags = { - ProjectName = "demo-internal" - Env = "dev" - Owner = "user@example.com" - BusinessUnit = "CORP" - ServiceClass = "Gold" - } -} -``` - ## Requirements Name | Version