Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make feature extraction more compact #12

Closed
Many98 opened this issue Nov 10, 2020 · 1 comment
Closed

Make feature extraction more compact #12

Many98 opened this issue Nov 10, 2020 · 1 comment
Assignees
@Many98 @srameon1

Comments

@Many98
Copy link
Collaborator

Many98 commented Nov 10, 2020

I see that currently classes for extraction scores GS/GC _ some_time_period have very similar interface. I suggest to use inheritance or do it as one function with parameter specifying on which period calculate score...
@Many98
Copy link
Collaborator Author

Many98 commented Nov 10, 2020

Possible not use object-oriented programming at all but instead do feature extraction in more functional way

@Many98 Many98 closed this as completed Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Many98 Many98

@srameon1 srameon1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Many98 @srameon1