Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/algorithm/sort.hpp defines compare_func but never uses it #58

Open
Quuxplusone opened this issue Dec 24, 2019 · 0 comments
Open

test/algorithm/sort.hpp defines compare_func but never uses it #58

Quuxplusone opened this issue Dec 24, 2019 · 0 comments

Comments

@Quuxplusone
Copy link

https://github.com/kvasir-io/mpl/blob/development/test/algorithm/sort.hpp#L16-L17

template <typename E1, typename E2>
using compare_func = bool_<(E1::value < E2::value)>;

but compare_func is never used in the test case that follows. It's not obvious how it would be passed to mpl[::eager?]::sort.

Also, ideally,

using empty_sort_test = eager::sort<list<>>;

would be followed by

static_assert(std::is_same_v<empty_sort_test, list<>>);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant