Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User test Feedback #7

Open
jacquelinekay opened this issue Feb 23, 2017 · 3 comments
Open

User test Feedback #7

jacquelinekay opened this issue Feb 23, 2017 · 3 comments

Comments

@jacquelinekay
Copy link

  • Consider setting a standard CMake variable such as KVASIR_TOOLCHAIN_DIR and logic for setting the default instead of having the user set the toolchain variable in their CMakeLists.txt.
  • When following the instructions on the README, I get a warning that CMAKE_TOOLCHAIN_FILE is not used. This should probably be removed from the documentation.
@cjsmeele
Copy link
Collaborator

cjsmeele commented Feb 23, 2017

  • Consider setting a standard CMake variable such as KVASIR_TOOLCHAIN_DIR and logic for setting the default instead of having the user set the toolchain variable in their CMakeLists.txt.

I suppose since we now use CMake toolchain files, we can set the Kvasir toolchain directory automatically from that file instead. I'll see if that works.

  • When following the instructions on the README, I get a warning that CMAKE_TOOLCHAIN_FILE is not used. This should probably be removed from the documentation.

This may be caused by re-running cmake with the TOOLCHAIN parameter in an existing (and generated) build directory. Could this be the case?
The toolchain file only needs to be specified when the build directory is first generated.

@jacquelinekay
Copy link
Author

Do you guys want to set -std=c++11 or c++14 or whatever standard we've decided on by default?

@CvRXX
Copy link
Contributor

CvRXX commented Feb 24, 2017

I don't know, I would like toolchain to be usable for other things than to use it for kvasir. And maybe other projects can't run on 11/14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants