Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gen 2-5 Allow Combinations of Egg Moves #4426

Open
pofehof opened this issue Jan 25, 2025 · 1 comment · May be fixed by #4444
Open

Gen 2-5 Allow Combinations of Egg Moves #4426

pofehof opened this issue Jan 25, 2025 · 1 comment · May be fixed by #4444
Labels
enhancement help wanted

Comments

@pofehof
Copy link

pofehof commented Jan 25, 2025

Describe the problem
I noticed that if you have a Pokemon with Egg Moves that are only possible from different sets of fathers (Gen 3 Blastoise with Haze and Flail), PKHeX sees this as legal solely due to them being Egg Moves. From what I understand, starting in Gen 6, both parents can pass down Egg Moves, allowing combinations like this to occur.

Expected behavior
Egg Moves from different sets of fathers should be impossible in Gen 2-5 and seen as illegal.
@pofehof pofehof added the bug label Jan 25, 2025
@Lusamine
Copy link
Collaborator

This is a known issue but there isn't a good method to handle it right now, so it has not been implemented. What's needed is an efficient and general method of checking which combos are not possible, as opposed to a less good method like hard-coding every combination.

abcboy101 added a commit to abcboy101/PKHeX that referenced this issue Feb 4, 2025
@abcboy101
Check Egg Move combinations for a valid father
3588e2c 
Closes kwsch#4426
@abcboy101 abcboy101 linked a pull request Feb 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check Egg Move combinations for a valid father abcboy101/PKHeX
2 participants
@Lusamine @pofehof