You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've forked this project to fix the following issues:
Fixed issue where sorting was ignoring changes in the data-sort-value attribute value. Basically jQuery caches the data-sort-value so your sort logic was using stale values whenever these values changed.
Fixed issue where sorting for any columns following a TH than spanned multiple columns.
Happy to create a PR if you would like any of these fixes merging in. I've noticed a few stale PRs so didn't want to waste my time creating PRs if they're just going to sit there.
Cheers!
The text was updated successfully, but these errors were encountered:
I'd be happy to merge if you can provide a detailed description of how to reproduce the issues you're solving — or better yet, an example. The biggest piece of friction for me when verifying fixes is setting up a scenario that allows me to verify the bug and fix. So if you can provide that, it's a simple merge 👍 Thanks!
I've forked this project to fix the following issues:
data-sort-value
attribute value. Basically jQuery caches thedata-sort-value
so your sort logic was using stale values whenever these values changed.Happy to create a PR if you would like any of these fixes merging in. I've noticed a few stale PRs so didn't want to waste my time creating PRs if they're just going to sit there.
Cheers!
The text was updated successfully, but these errors were encountered: