Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interested in these fixes? #38

Open
KarlPurk opened this issue Aug 28, 2017 · 1 comment
Open

Interested in these fixes? #38

KarlPurk opened this issue Aug 28, 2017 · 1 comment

Comments

@KarlPurk
Copy link

I've forked this project to fix the following issues:

  1. Fixed issue where sorting was ignoring changes in the data-sort-value attribute value. Basically jQuery caches the data-sort-value so your sort logic was using stale values whenever these values changed.
  2. Fixed issue where sorting for any columns following a TH than spanned multiple columns.

Happy to create a PR if you would like any of these fixes merging in. I've noticed a few stale PRs so didn't want to waste my time creating PRs if they're just going to sit there.

Cheers!

@kylefox
Copy link
Owner

kylefox commented Sep 2, 2017

Sure, those sound good.

I'd be happy to merge if you can provide a detailed description of how to reproduce the issues you're solving — or better yet, an example. The biggest piece of friction for me when verifying fixes is setting up a scenario that allows me to verify the bug and fix. So if you can provide that, it's a simple merge 👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants