Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes should be parsed using the binary-parser module #10

Open
kylestev opened this issue Nov 1, 2015 · 1 comment
Open

Attributes should be parsed using the binary-parser module #10

kylestev opened this issue Nov 1, 2015 · 1 comment

Comments

@kylestev
Copy link
Owner

kylestev commented Nov 1, 2015

Now that the binary-parser PR has been merged, it will give us a decent performance increase if we are able to utilize it when reading attributes.

@kylestev
Copy link
Owner Author

kylestev commented Nov 1, 2015

While not necessarily in the scope of this issue, it might be possible to also write a parser for the bytecode instructions and then pass them off to the InstructionFactory when instructions are created. While it might require a bit of work to implement, I believe a significant portion of the code could be auto generated based on other definitions available.

@kylestev kylestev modified the milestone: v0.1 Release Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant