Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be aware of Java class file versions when writing data #9

Open
kylestev opened this issue Nov 1, 2015 · 1 comment
Open

Comments

@kylestev
Copy link
Owner

kylestev commented Nov 1, 2015

Instructions and constant pool entries/types that are not implemented in the JVM version for a class file should not be able to be written to a file.

At parse time, this library does not modify entries in the constant pool nor does it optimize instructions for later versions of the JVM spec. There needs to be an error thrown when adding instructions to a class method or a constant pool entry that does not conform to the current class file's JVM version.

TSedlar added a commit that referenced this issue Nov 2, 2015
Added AbstractInstruction#supported and Writing#UnsupportedOpcode exception.

refs #9
@kylestev
Copy link
Owner Author

kylestev commented Nov 3, 2015

by merging #14 we only need to worry about verifying the constant pool entries as well as the attributes

@kylestev kylestev modified the milestone: v0.1 Release Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant