-
Notifications
You must be signed in to change notification settings - Fork 35
Hello Messages compliance - optional elements #379
Comments
@erickvermot considering #157 (class improved inheritance), I think that an easier solution would be to implement a This is just an example on how to deal with this issue (and all the associated issues) considering the inheritance improvements I've made (but are not yet merged on this repo). |
@diraol I see your point with the genericheader, and I think it is good for the unpack of a generic version as you said. But I think you misunderstood the issue for in this issue I am referring to the specific v0x01 Hello message. |
From the spec: "Implementations must be prepared to receive a hello message that includes a body, ignoring its contents, to allow for later extensions". As nobody is using it yet, I'm lowering the priority. |
Hello messages should be able to hold a body with optional elements, but pyof v0x01 currently does not accept hello messages with a body.
Any element should be accepted, for there may be expansion in the future.
For now, only VERSIONBITMAP elements are known, and hello messages should be able to carry it.
This is the same problem as stated in as #303, but was only developed for v0x04.
The proposed code is not working though, and need fix. (#378)
I suggest we fix it and then simply copy the code to the v0x01 lib.
The text was updated successfully, but these errors were encountered: