From 4a824e870d86171353a0b7d9106bb24e53cff8f5 Mon Sep 17 00:00:00 2001 From: BlackYps <52536103+BlackYps@users.noreply.github.com> Date: Fri, 29 Nov 2024 23:50:58 +0100 Subject: [PATCH] Fix matchmaker games not launching (#6565) --- docs/_posts/2024-11-29-3814.md | 16 ++++++++++++++++ lua/ui/lobby/autolobby.lua | 2 +- lua/ui/lobby/changelogData.lua | 19 ++++++++++++++++++- lua/version.lua | 6 +++--- mod_info.lua | 2 +- 5 files changed, 39 insertions(+), 6 deletions(-) create mode 100644 docs/_posts/2024-11-29-3814.md diff --git a/docs/_posts/2024-11-29-3814.md b/docs/_posts/2024-11-29-3814.md new file mode 100644 index 0000000000..e7c6f3d3a8 --- /dev/null +++ b/docs/_posts/2024-11-29-3814.md @@ -0,0 +1,16 @@ +--- +layout: post +title: Game version 3814 +permalink: changelog/3814 +--- + + +# Game version 3814 (29th of November, 2024) + +A log statement accessed an uninitialized variable, which causes matchmaker games to crash. +We fixed the log statement and matchmaker should now work again. +Special thanks to clyf and Nomander for being the emergency response team! + +With kind regards, + +BlackYps \ No newline at end of file diff --git a/lua/ui/lobby/autolobby.lua b/lua/ui/lobby/autolobby.lua index 2e31c407d0..19ef125605 100644 --- a/lua/ui/lobby/autolobby.lua +++ b/lua/ui/lobby/autolobby.lua @@ -42,7 +42,7 @@ local AutolobbyCommunicationsInstance = false ---@param natTraversalProvider any ---@return UIAutolobbyCommunications function CreateLobby(protocol, localPort, desiredPlayerName, localPlayerUID, natTraversalProvider) - LOG("CreateLobby", protocol, localPort, desiredPlayerName, localPlayerUID, natTraversalProvider) + LOG("CreateLobby", protocol, localPort, desiredPlayerName, localPlayerUID) -- create the interface, needs to be done before the lobby is local playerCount = tonumber(GetCommandLineArg("/players", 1)[1]) or 8 diff --git a/lua/ui/lobby/changelogData.lua b/lua/ui/lobby/changelogData.lua index 5ed5f04771..7ec35e243b 100644 --- a/lua/ui/lobby/changelogData.lua +++ b/lua/ui/lobby/changelogData.lua @@ -1,8 +1,25 @@ ---@type number -last_version = 3813 +last_version = 3814 ---@type PatchNotes[] gamePatches = { + { + version = 3814, + name = "Hotfix", + hasPrettyGithubRelease = true, + hasPrettyPatchnotes = false, + description = { + "# Game version 3814 (29th of November, 2024)", + "", + "A log statement accessed an uninitialized variable, which causes matchmaker games to crash.", + "We fixed the log statement and matchmaker should now work again.", + "Special thanks to clyf and Nomander for being the emergency response team!", + "", + "With kind regards,", + "", + "BlackYps", + }, + }, { version = 3813, name = "Developers patch", diff --git a/lua/version.lua b/lua/version.lua index 5c1b0e0bb4..3299c7914d 100644 --- a/lua/version.lua +++ b/lua/version.lua @@ -34,9 +34,9 @@ local Commit = 'unknown' -- The use of `'` instead of `"` is **intentional** --#endregion -local Version = "3813" ----@alias PATCH "3813" ----@alias VERSION "1.5.3813" +local Version = "3814" +---@alias PATCH "3814" +---@alias VERSION "1.5.3814" ---@return PATCH # Game release function GetVersion() LOG(string.format('Supreme Commander: Forged Alliance Lua version %s at %s (%s)', Version, GameType, Commit)) diff --git a/mod_info.lua b/mod_info.lua index 186cd3c102..d1eb0427bd 100644 --- a/mod_info.lua +++ b/mod_info.lua @@ -27,7 +27,7 @@ -- - https://github.com/FAForever/fa/blob/deploy/fafdevelop/lua/MODS.LUA name = "Forged Alliance Forever" -version = 3813 -- needs to be an integer as it is parsed as a short (16 bit integer) +version = 3814 -- needs to be an integer as it is parsed as a short (16 bit integer) _faf_modname='faf' copyright = "Forged Alliance Forever Community" description = "Forged Alliance Forever extends Forged Alliance, bringing new patches, game modes, units, ladder, and much more!"