-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: password is removed from DB if registry is modified without checking the change password option #2875
base: main
Are you sure you want to change the base?
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 5.27% (-0.01% 🔻) |
395/7491 |
🔴 | Branches | 4.57% (-0.01% 🔻) |
237/5182 |
🔴 | Functions | 3.16% (-0% 🔻) |
78/2471 |
🔴 | Lines | 5.19% (-0.01% 🔻) |
380/7323 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 93f2faa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be solved by the core part.
Merge activity
|
feca9fb
to
457c15c
Compare
…king the change password option
457c15c
to
93f2faa
Compare
resolves #2874
Changes:
Added a new mutation
ContainerRegistryEditorModalModifyWithoutPasswordMutation
to handle registry modifications when the password remains unchanged. This prevents sending unnecessary password data during updates.Implementation Details:
handleSave
function to use the appropriate mutation based on whether the password was modifiedRationale:
This change improves security by not transmitting password data when it hasn't been modified, following the principle of least privilege.
Checklist:
Testing Requirements: