refactor: improve resource allocation form item labels with resource details API #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6 tasks
yomybaby
changed the title
useResourceResourceSlotDetailsuseResourceSlotDetails
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.82% | 140/4965 |
| 🔴 | Branches | 3% (-0.01% 🔻) |
101/3370 |
| 🔴 | Functions | 1.66% | 27/1631 |
| 🔴 | Lines | 2.69% | 131/4875 |
Test suite run success
51 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from a3638bf
yomybaby
force-pushed
the
feature/use-resource-slot-details
branch
from
7ab7cb4
to
6b32b37
Compare
yomybaby
changed the title
useResourceSlotDetails
yomybaby
force-pushed
the
feature/use-resource-slot-details
branch
2 times, most recently
from
e42dd94
to
a7394f7
Compare
yomybaby
force-pushed
the
feature/use-resource-slot-details
branch
from
a7394f7
to
5fecf76
Compare
yomybaby
changed the title
yomybaby
changed the title
Merge activity
|
…details API (#2485) ### TL;DR Add functionality to use `resourceSlotsDetails` for better resource information display in `ResourceAllocationFormItems` and `ResourceNumber` components. ### What changed? - Imported `useResourceSlotsDetails` from `backendai` hooks - Added `resourceSlotsDetails` usage in `ResourceAllocationFormItems` - Updated `ResourceNumber` component to use `resourceSlotsDetails` for better display of resources - Adjusted stale time for `useResourceSlotsDetails` query ### How to test? 1. Ensure that the resource display reflects human-readable names and units as provided by `resourceSlotsDetails`. 2. Check the display of CPU and memory resources in the `ResourceAllocationFormItems`. 3. Verify the `ResourceNumber` component displays the updated format and units. ### Why make this change? Enhances the clarity and accuracy of resource information displayed to the users through the `ResourceAllocationFormItems` and `ResourceNumber` components by utilizing detailed slot information. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
feature/use-resource-slot-details
branch
from
5fecf76
to
a3638bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add functionality to use
resourceSlotsDetailsfor better resource information display inResourceAllocationFormItemsandResourceNumbercomponents.What changed?
useResourceSlotsDetailsfrombackendaihooksresourceSlotsDetailsusage inResourceAllocationFormItemsResourceNumbercomponent to useresourceSlotsDetailsfor better display of resourcesuseResourceSlotsDetailsqueryHow to test?
resourceSlotsDetails.ResourceAllocationFormItems.ResourceNumbercomponent displays the updated format and units.Why make this change?
Enhances the clarity and accuracy of resource information displayed to the users through the
ResourceAllocationFormItemsandResourceNumbercomponents by utilizing detailed slot information.Checklist: (if applicable)