Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase request timeout #2826

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Nov 7, 2024

resolves #2825

Increases the default request timeout duration from 10-20 seconds to a consistent 30 seconds across all session and folder operations to prevent timeouts during high-latency conditions.

Checklist:

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Nov 7, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:XS ~10 LoC label Nov 7, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

@agatha197 agatha197 added the type:fix Fix features that are not working label Nov 7, 2024 — with Graphite App
@yomybaby yomybaby changed the title fix: increase request timeout of filebrowser fix: increase request timeout of filebrowser session Nov 7, 2024
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 force-pushed the fix/increase-request-timeout-of-filebrowser branch from fac73b1 to ee59f50 Compare November 7, 2024 05:04
@github-actions github-actions bot added area:lib Library and SDK related issue. size:S 10~30 LoC and removed size:XS ~10 LoC labels Nov 7, 2024
@agatha197 agatha197 changed the title fix: increase request timeout of filebrowser session fix: increase request timeout Nov 7, 2024
@agatha197 agatha197 requested a review from adrysn November 7, 2024 05:05
Copy link

github-actions bot commented Nov 7, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.82% 349/7244
🔴 Branches 4.41% 220/4991
🔴 Functions 2.8% 67/2389
🔴 Lines 4.71% 334/7085

Test suite run success

96 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from d286c90

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Nov 8, 2024

Merge activity

resolves #2825

Increases the default request timeout duration from 10-20 seconds to a consistent 30 seconds across all session and folder operations to prevent timeouts during high-latency conditions.

**Checklist:**

- [x] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@yomybaby yomybaby force-pushed the fix/increase-request-timeout-of-filebrowser branch from ee59f50 to d286c90 Compare November 8, 2024 02:09
@graphite-app graphite-app bot merged commit d286c90 into main Nov 8, 2024
7 checks passed
@graphite-app graphite-app bot deleted the fix/increase-request-timeout-of-filebrowser branch November 8, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:lib Library and SDK related issue. size:S 10~30 LoC type:fix Fix features that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the session request timeout of the filebrowser
2 participants