fix: use || operator instead of unreachable ??
#2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
agatha197
added
the
type:fix
Graphite App
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.29% | 395/7462 |
| 🔴 | Branches | 4.59% (-0% 🔻) |
237/5166 |
| 🔴 | Functions | 3.16% | 78/2466 |
| 🔴 | Lines | 5.21% | 380/7295 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from ae54e8a
yomybaby
requested changes
Nov 14, 2024
Comment on lines
96
to
100
| ((iSizeToSize(_.toString(agent?.mem_cur_bytes), 'g') | ||
| ?.number ?? 0) / | ||
| (iSizeToSize(parsedAvailableSlots?.mem, 'g')?.number ?? | ||
| ?.number || 0) / | ||
| (iSizeToSize(parsedAvailableSlots?.mem, 'g')?.number || | ||
| 0)) * | ||
| 100 ?? 0 | ||
| 100 |
There was a problem hiding this comment.
Suggested change
| ((iSizeToSize(_.toString(agent?.mem_cur_bytes), 'g') | |
| ?.number ?? 0) / | |
| (iSizeToSize(parsedAvailableSlots?.mem, 'g')?.number ?? | |
| ?.number || 0) / | |
| (iSizeToSize(parsedAvailableSlots?.mem, 'g')?.number || | |
| 0)) * | |
| 100 ?? 0 | |
| 100 | |
| (_.toNumber( | |
| iSizeToSize(_.toString(agent?.mem_cur_bytes), 'g') | |
| ?.number, | |
| ) / | |
| _.toNumber( | |
| iSizeToSize(parsedAvailableSlots?.mem, 'g')?.number, | |
| )) * | |
| 100 || 0 |
To further improve, instead of using || 0 to handle NaN, we can modify BAIProgressWithLabel to display the percent as disabled or distinguish it in some way when it is NaN.
agatha197
force-pushed
the
fix/nullish-value
branch
from
e1dfd19
to
381e3ed
Compare
yomybaby
force-pushed
the
fix/nullish-value
branch
from
381e3ed
to
edd4992
Compare
yomybaby
approved these changes
Nov 21, 2024
Merge activity
|
Fix `Right operand of ?? is unreachable because the left operand is never nullish.` error by using `||` operator. **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
fix/nullish-value
branch
from
e73e169
to
ae54e8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Right operand of ?? is unreachable because the left operand is never nullish.error by using||operator.Checklist: (if applicable)