Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support new status PREPARED of session and kernel #2848

Merged

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Nov 13, 2024

related to lablup/backend.ai#2647

We decided to add a new session and kernel status called 'PREPARED' to Backend.AI.
This status indicates that the session is ready to be created and doesn't require any miscellaneous tasks such as pulling images.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minimum required manager version: 24.12.0
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Nov 13, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:S 10~30 LoC label Nov 13, 2024
Copy link
Member Author

fregataa commented Nov 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Nov 13, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 5.27% 386/7319
🔴 Branches 4.56% 229/5027
🔴 Functions 3.15% 76/2414
🔴 Lines 5.18% 371/7158

Test suite run success

109 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 7265dfb

@fregataa fregataa changed the title feat: Support new status of session and kernel feat: Support new status PREPARED of session and kernel Nov 13, 2024
@fregataa fregataa marked this pull request as ready for review November 13, 2024 10:03
@fregataa fregataa added this to the 24.12 milestone Nov 13, 2024
@fregataa fregataa added the urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. label Nov 13, 2024
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

agatha197

This comment was marked as duplicate.

Copy link

graphite-app bot commented Nov 14, 2024

Merge activity

related to lablup/backend.ai#2647

We decided to add a new session and kernel status called 'PREPARED' to Backend.AI.
This status indicates that the session is ready to be created and doesn't require any miscellaneous tasks such as pulling images.

**Checklist:** (if applicable)

- [ ] Mention to the original issue
- [ ] Documentation
- [x] Minimum required manager version: 24.12.0
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@fregataa fregataa force-pushed the topic/11-13-feat_support_new_status_of_session_and_kernel branch from ae8dcb4 to 7265dfb Compare November 14, 2024 06:45
@graphite-app graphite-app bot merged commit 7265dfb into main Nov 14, 2024
6 checks passed
@graphite-app graphite-app bot deleted the topic/11-13-feat_support_new_status_of_session_and_kernel branch November 14, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants