Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NEO sider's toggle button and refactoring #2853

Merged
merged 1 commit into from
Nov 20, 2024

Commits on Nov 20, 2024

  1. feat: NEO sider's toggle button and refactoring (#2853)

    ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/XqC2uNFuj0wg8I60sMUh/c3c9b8e7-7063-4fb9-b717-c805530a5a43.png)
    
    **Changes:**
    - Added keyboard shortcut '[' to toggle sidebar collapse state
    - Introduced a collapsible button on the sidebar that appears on hover
    - Moved sidebar footer content into a more structured layout
    - Added `useKeyboardShortcut` hook to handle keyboard shortcuts when no input is focused
    - Refactored BAISider component to use forwardRef and improve layout structure
    - Standardized sidebar width constants (COLLAPSED_SIDER_WIDTH = 74, SIDER_WIDTH = 240)
    - Removed bottomText prop from BAISider in favor of direct content rendering
    - Added hover detection for showing/hiding the collapse toggle button
    
    **Testing Requirements:**
    1. Verify the '[' keyboard shortcut toggles sidebar when no input is focused
    2. Check that the collapse button appears on sidebar hover
    3. Confirm sidebar footer content displays correctly in both expanded/collapsed states
    4. Test that keyboard shortcuts don't trigger when inputs or modals are focused
    yomybaby committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    33f7fba View commit details
    Browse the repository at this point in the history